From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Use gnulib c-ctype module, not <ctype.h>
Date: Tue, 9 Sep 2025 14:01:42 -0400 [thread overview]
Message-ID: <3208ce09-e47c-4355-898e-321891a26558@simark.ca> (raw)
In-Reply-To: <87qzwfpl62.fsf@tromey.com>
On 9/9/25 1:53 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> As far as I'm concerned, this patch series LGTM, I'm not aware of better
> Simon> alternatives.
>
> Simon> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> I'm going to check this in now.
>
> Just as a reminder to everyone, gdb should generally use these new
> "c-ctype" wrapper functions and not <ctype.h>.
>
> One idea I had for enforcement was to write a new pre-commit script that
> looked for includes of ctype.h or safe-ctype.h. WDYT?
>
> Tom
1. Should all includes of ctype.h and safe-ctype.h be removed from GDB
right now, in any case?
2. Is ctype.h available transitively anyway? If so, we could add a
call to a ctype.h function without adding an include, so the script
wouldn't catch it. The script wouldn't hurt, but I don't think it would
be terribly useful.
Simon
next prev parent reply other threads:[~2025-09-09 18:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 13:13 Tom Tromey
2025-08-06 13:13 ` [PATCH 1/3] Import the c-ctype module from gnulib Tom Tromey
2025-08-06 13:13 ` [PATCH 2/3] Use c-ctype.h (not safe-ctype.h) in gdb Tom Tromey
2025-08-06 13:13 ` [PATCH 3/3] Use gnulib c-ctype module " Tom Tromey
2025-08-06 19:46 ` [PATCH 0/3] Use gnulib c-ctype module, not <ctype.h> Simon Marchi
2025-08-07 20:39 ` Tom Tromey
2025-08-20 17:14 ` Simon Marchi
2025-09-09 17:53 ` Tom Tromey
2025-09-09 18:01 ` Simon Marchi [this message]
2025-09-09 18:55 ` Tom Tromey
2025-10-14 13:00 ` Guinevere Larsen
2025-10-14 19:19 ` Tom Tromey
2025-10-16 15:30 ` Tom Tromey
2025-10-16 21:50 ` Luis
2025-10-21 12:59 ` Tom Tromey
2025-10-21 17:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3208ce09-e47c-4355-898e-321891a26558@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox