From: Tom Tromey <tromey@adacore.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Use gnulib c-ctype module, not <ctype.h>
Date: Tue, 14 Oct 2025 13:19:12 -0600 [thread overview]
Message-ID: <87y0pdthov.fsf@tromey.com> (raw)
In-Reply-To: <b23ef4b9-6f82-428c-9445-58f13c858e7e@redhat.com> (Guinevere Larsen's message of "Tue, 14 Oct 2025 10:00:05 -0300")
Guinevere> This patch series causes compilation to fail when using clang to
Guinevere> compile GDB in fedora rawhide.
Guinevere> The errors look like this:
Guinevere> /usr/bin/ld: gdbsupport/common-utils-ipa.o: in function
Guinevere> `strtoulst(char const*, char const**, int)':
Guinevere> /home/buildbot/buildbot/binutils-gdb-clang-fedrawhide-x86_64/build/gdbserver/../gdbsupport/common-utils.cc:256:(.text+0xa3d):
Guinevere> undefined reference to `c_isalnum'
Guinevere> /usr/bin/ld:
Guinevere> /home/buildbot/buildbot/binutils-gdb-clang-fedrawhide-x86_64/build/gdbserver/../gdbsupport/common-utils.cc:256:(.text+0xb0a):
Guinevere> undefined reference to `c_isalnum'
Guinevere> clang++: error: linker command failed with exit code 1 (use -v to see
Guinevere> invocation)
Guinevere> I have no idea why the newest clang has this problem and no other
Guinevere> compiler does, might be a bug, but regardless, it is causing the clang
Guinevere> buildbot to stop working
gnulib + libinproctrace.so + clang ... lol
I was able to reproduce this. I am not completely sure what to do here.
Maybe for the IPA case we can use <ctype.h> conditionally. I'll
probably take this route.
Another option would be to write our own thing akin to "c-ctype" but
that uses the libiberty code instead. That would work since
libinproctrace.so seems to link against libiberty.
I am more and more tempted to remove gnulib entirely.
I also wonder - is anyone using libinproctrace.so?
Tom
next prev parent reply other threads:[~2025-10-14 19:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 13:13 Tom Tromey
2025-08-06 13:13 ` [PATCH 1/3] Import the c-ctype module from gnulib Tom Tromey
2025-08-06 13:13 ` [PATCH 2/3] Use c-ctype.h (not safe-ctype.h) in gdb Tom Tromey
2025-08-06 13:13 ` [PATCH 3/3] Use gnulib c-ctype module " Tom Tromey
2025-08-06 19:46 ` [PATCH 0/3] Use gnulib c-ctype module, not <ctype.h> Simon Marchi
2025-08-07 20:39 ` Tom Tromey
2025-08-20 17:14 ` Simon Marchi
2025-09-09 17:53 ` Tom Tromey
2025-09-09 18:01 ` Simon Marchi
2025-09-09 18:55 ` Tom Tromey
2025-10-14 13:00 ` Guinevere Larsen
2025-10-14 19:19 ` Tom Tromey [this message]
2025-10-16 15:30 ` Tom Tromey
2025-10-16 21:50 ` Luis
2025-10-21 12:59 ` Tom Tromey
2025-10-21 17:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0pdthov.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox