From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id brTzMLZrwGhDAD4AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 14:02:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757440950; bh=cBeA/54ETRxWXZq2h+pYqrZ7SPIqM8jmcaRSinqPjfg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LaWYo7NaQZRiFv+mmtdA01SlGSQ6g3wwq2kjUzjCSIOut0fInmjF/afGudHU16C26 tU9yf1KDdnYTrksFfcnI/fG2OHbEYwAwCzsOP5RVLpunor068/ub9rzY7nh3TAZQxy rZ6323mAs4K/V+In2eCS3XPpumtNNH6DHDZctXSU= Received: by simark.ca (Postfix, from userid 112) id B60451E04C; Tue, 09 Sep 2025 14:02:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=o/0kt8HH; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 29B531E04C for ; Tue, 09 Sep 2025 14:02:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 72CB73858C60 for ; Tue, 9 Sep 2025 18:02:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72CB73858C60 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=o/0kt8HH Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id C1AC73858C41 for ; Tue, 9 Sep 2025 18:01:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1AC73858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1AC73858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757440903; cv=none; b=pgYY9gNDoTq37EBtZhioFCQKWF8NWuTxI0LI6VJDR3qT1ZOb8KOe1ZxpgaFKUdXPZ27dAHuLgvQ5sMjIB5Rh4PfzY/JxpRbUvXYRPZAt8mDI8qlh2tcpv+gEdauKG/RU7NmCQfX++Xk1sTzylETyc483U9w40Dsj7AWrg3cdOZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757440903; c=relaxed/simple; bh=cBeA/54ETRxWXZq2h+pYqrZ7SPIqM8jmcaRSinqPjfg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=p5KCdMNhyG2tkYKFCzqEq/JJp6DK4mXjzPZHW2+ZfGpuHVZ0u7hCjENTGsUiZOerHopLc31SvPy9wE7bm+v0JBEGG8AcuCNcDR+P+xtaScJrNPrG8nwaVyqy8O+NCGpdAH7PMU7ez8a67D8kZU7efde1MkeMQxGxaAs6QJu+VGs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1AC73858C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757440903; bh=cBeA/54ETRxWXZq2h+pYqrZ7SPIqM8jmcaRSinqPjfg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=o/0kt8HHzvb9L3paSY89eYkc1K5ROgAX8iYeeqqRdpTbzGAKo3HdzDWw9kGkNLrA6 W94X38s0X+QrYbwGcRLVgJidjQudv2GTaIq/9ppq6l0A2y90e916sXG6S6iUPFHHjA YtGDYnPLovAb6Z+VedVLDd3W5HcrCdmsd2v1q7q8= Received: by simark.ca (Postfix) id 24CF91E04C; Tue, 09 Sep 2025 14:01:43 -0400 (EDT) Message-ID: <3208ce09-e47c-4355-898e-321891a26558@simark.ca> Date: Tue, 9 Sep 2025 14:01:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Use gnulib c-ctype module, not To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250806-gnulib-c-ctype-v1-0-10f33e9f22a4@adacore.com> <87h5yiq32b.fsf@tromey.com> <87qzwfpl62.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87qzwfpl62.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/9/25 1:53 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> As far as I'm concerned, this patch series LGTM, I'm not aware of better > Simon> alternatives. > > Simon> Approved-By: Simon Marchi > > I'm going to check this in now. > > Just as a reminder to everyone, gdb should generally use these new > "c-ctype" wrapper functions and not . > > One idea I had for enforcement was to write a new pre-commit script that > looked for includes of ctype.h or safe-ctype.h. WDYT? > > Tom 1. Should all includes of ctype.h and safe-ctype.h be removed from GDB right now, in any case? 2. Is ctype.h available transitively anyway? If so, we could add a call to a ctype.h function without adding an include, so the script wouldn't catch it. The script wouldn't hurt, but I don't think it would be terribly useful. Simon