From: Luis Machado <luis.machado@linaro.org>
To: Eli Zaretskii <eliz@gnu.org>, Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: remove unused includes from dwarf2read.c
Date: Mon, 14 Oct 2019 18:02:00 -0000 [thread overview]
Message-ID: <2fc75879-f6a5-bb6a-afc5-dc1477375147@linaro.org> (raw)
In-Reply-To: <83r23fie80.fsf@gnu.org>
On 10/14/19 11:38 AM, Eli Zaretskii wrote:
>> Date: Mon, 14 Oct 2019 10:21:50 -0400
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> I pushed it after Tom de Vries reviewed it on Gerrit:
>>
>> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/24
>
> Does this mean that now we need to look for patches in two places?
> Can Gerrit be set up to forward the review comments to the list?
>
> Also, if some of us decides to do the review on Gerrit, does it mean
> all the others need to do that as well?
>
The transition to some better (restrictions may apply) patch reviewing
system is a good thing, but i agree we should think further about it.
Personally i think we should discuss and then decide on a date by which
we will fully transition to it.
Otherwise there is the potential for confusion since people will have to
look into two different places for patches. People may review stuff on
gerrit and the mailing list at the same time. This split isn't great and
is prone to cause collision of suggestions due to reviewers not being
aware of each other. etc.
Ideally we'd put gerrit up when it is fully configured and functional,
being able to merge patches automatically. Then only maintainers will be
able to +2 (approve) patches and verify contributors meet the legal
requisites as is already the case with mailing lists?
next prev parent reply other threads:[~2019-10-14 18:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 4:54 Simon Marchi
2019-10-14 14:22 ` Simon Marchi
2019-10-14 14:39 ` Eli Zaretskii
2019-10-14 15:18 ` Simon Marchi
2019-10-14 17:12 ` Gerrit (was: [PATCH] gdb: remove unused includes from dwarf2read.c) Eli Zaretskii
2019-10-14 17:31 ` Gerrit Simon Marchi
2019-10-14 17:56 ` Gerrit Eli Zaretskii
2019-10-14 18:03 ` Gerrit Tom Tromey
2019-10-14 18:32 ` Gerrit Eli Zaretskii
2019-10-15 1:33 ` Gerrit Simon Marchi
2019-10-15 8:51 ` Gerrit Eli Zaretskii
2019-10-15 15:57 ` Gerrit Sergio Durigan Junior
2019-10-15 16:33 ` Gerrit Eli Zaretskii
2019-10-15 17:09 ` Gerrit Sergio Durigan Junior
2019-10-15 17:31 ` Gerrit Eli Zaretskii
2019-10-15 17:49 ` Gerrit Sergio Durigan Junior
2019-10-14 23:51 ` Gerrit Simon Marchi
2019-10-14 18:02 ` Luis Machado [this message]
2019-10-14 20:58 ` [PATCH] gdb: remove unused includes from dwarf2read.c Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fc75879-f6a5-bb6a-afc5-dc1477375147@linaro.org \
--to=luis.machado@linaro.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox