Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH] gdb: remove unused includes from dwarf2read.c
Date: Sun, 13 Oct 2019 04:54:00 -0000	[thread overview]
Message-ID: <20191013045218.3261363-1-simon.marchi@polymtl.ca> (raw)

include-what-you-use says:

../../../src/binutils-gdb/gdb/dwarf2read.c should remove these lines:
- #include <ctype.h>  // lines 67-67
- #include <sys/stat.h>  // lines 59-59
- #include <sys/types.h>  // lines 83-83
- #include <cmath>  // lines 88-88
- #include <forward_list>  // lines 90-90
- #include <set>  // lines 89-89
- #include <unordered_set>  // lines 85-85
- #include "completer.h"  // lines 60-60
- #include "expression.h"  // lines 44-44
- #include "gdbsupport/byte-vector.h"  // lines 78-78
- #include "gdbsupport/filestuff.h"  // lines 71-71
- #include "gdbsupport/gdb_unlinker.h"  // lines 74-74

After a quick glance, that makes sense, so this patch removes them.

Change-Id: I13cfcb2f1d747144fddba7f66b329630b79dae90
---
 gdb/dwarf2read.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index ee9df34ed27c..5d072f569ec5 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -41,7 +41,6 @@
 #include "buildsym.h"
 #include "demangle.h"
 #include "gdb-demangle.h"
-#include "expression.h"
 #include "filenames.h"	/* for DOSish file names */
 #include "macrotab.h"
 #include "language.h"
@@ -56,38 +55,27 @@
 #include "addrmap.h"
 #include "typeprint.h"
 #include "psympriv.h"
-#include <sys/stat.h>
-#include "completer.h"
 #include "gdbsupport/vec.h"
 #include "c-lang.h"
 #include "go-lang.h"
 #include "valprint.h"
 #include "gdbcore.h" /* for gnutarget */
 #include "gdb/gdb-index.h"
-#include <ctype.h>
 #include "gdb_bfd.h"
 #include "f-lang.h"
 #include "source.h"
-#include "gdbsupport/filestuff.h"
 #include "build-id.h"
 #include "namespace.h"
-#include "gdbsupport/gdb_unlinker.h"
 #include "gdbsupport/function-view.h"
 #include "gdbsupport/gdb_optional.h"
 #include "gdbsupport/underlying.h"
-#include "gdbsupport/byte-vector.h"
 #include "gdbsupport/hash_enum.h"
 #include "filename-seen-cache.h"
 #include "producer.h"
 #include <fcntl.h>
-#include <sys/types.h>
 #include <algorithm>
-#include <unordered_set>
 #include <unordered_map>
 #include "gdbsupport/selftest.h"
-#include <cmath>
-#include <set>
-#include <forward_list>
 #include "rust-lang.h"
 #include "gdbsupport/pathstuff.h"
 
-- 
2.23.0


             reply	other threads:[~2019-10-13  4:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13  4:54 Simon Marchi [this message]
2019-10-14 14:22 ` Simon Marchi
2019-10-14 14:39   ` Eli Zaretskii
2019-10-14 15:18     ` Simon Marchi
2019-10-14 17:12       ` Gerrit (was: [PATCH] gdb: remove unused includes from dwarf2read.c) Eli Zaretskii
2019-10-14 17:31         ` Gerrit Simon Marchi
2019-10-14 17:56           ` Gerrit Eli Zaretskii
2019-10-14 18:03             ` Gerrit Tom Tromey
2019-10-14 18:32               ` Gerrit Eli Zaretskii
2019-10-15  1:33                 ` Gerrit Simon Marchi
2019-10-15  8:51                   ` Gerrit Eli Zaretskii
2019-10-15 15:57                     ` Gerrit Sergio Durigan Junior
2019-10-15 16:33                       ` Gerrit Eli Zaretskii
2019-10-15 17:09                         ` Gerrit Sergio Durigan Junior
2019-10-15 17:31                           ` Gerrit Eli Zaretskii
2019-10-15 17:49                             ` Gerrit Sergio Durigan Junior
2019-10-14 23:51             ` Gerrit Simon Marchi
2019-10-14 18:02     ` [PATCH] gdb: remove unused includes from dwarf2read.c Luis Machado
2019-10-14 20:58       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191013045218.3261363-1-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox