From: Luis Machado <lgustavo@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH, v2] Fixup test names starting with uppercase
Date: Tue, 15 Nov 2016 19:52:00 -0000 [thread overview]
Message-ID: <2bdcf3fe-3606-b5fb-f71d-d2fac437b81b@codesourcery.com> (raw)
In-Reply-To: <1fe09c2b-e293-f7d3-a004-5659ed4e8160@redhat.com>
On 11/15/2016 01:28 PM, Pedro Alves wrote:
> On 11/12/2016 05:53 AM, Luis Machado wrote:
>> This fixes the offender testcases that have test names starting with
>> uppercase.
>>
>> I also tried to catch cases where we set the test names via variables.
>>
>> We should probably adopt a policy and stick with it. If the way to go is
>> all lowercase, then the following patch should hopefully help clean some
>> of the inconsistencies up. Otherwise, we should go the other way and adjust
>> the test names to start with uppercase.
>
> I agree with lowercase. It's what we use most pervasively, and I've
> asked people to lowercase messages in review in the past. The fewer
> (bad) examples people can crib from, the better. So thanks for doing this.
>
Great. I'll polish the regular expression and i'll try to catch more
offenders.
While at it, do we also want to lowercase debugging messages emitted
from perror/error/warning/verbose etc? I could do that in a separate patch.
prev parent reply other threads:[~2016-11-15 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 5:53 Luis Machado
2016-11-15 19:28 ` Pedro Alves
2016-11-15 19:52 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bdcf3fe-3606-b5fb-f71d-d2fac437b81b@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox