Re: [PATCH, v2] Fixup test names starting with uppercase

[Pedro Alves <palves@redhat.com>]

On 11/12/2016 05:53 AM, Luis Machado wrote:
> This fixes the offender testcases that have test names starting with
> uppercase.
> 
> I also tried to catch cases where we set the test names via variables.
> 
> We should probably adopt a policy and stick with it. If the way to go is
> all lowercase, then the following patch should hopefully help clean some
> of the inconsistencies up. Otherwise, we should go the other way and adjust
> the test names to start with uppercase.

I agree with lowercase.  It's what we use most pervasively, and I've
asked people to lowercase messages in review in the past.  The fewer
(bad) examples people can crib from, the better.  So thanks for doing this.

> 
> There is also the question about capitalization of architecture names,
> technology names (UST, TE) and language names (Pascal/Python/Rust).

I think all those are fine to capitalize.

> -    unsupported "ARM NEON is not supported"
> +    unsupported "arm NEON is not supported"

(If we lowercased arm, why not neon?)

Likewise, I think ABI, GDB, MI, CLI, PowerPC, LZMA, UST, all lowercased
at least once in the patch, sometimes inconsistently, can/should remain uppercase.

Also noticed:

> --- a/gdb/testsuite/gdb.base/watch_thread_num.exp
> +++ b/gdb/testsuite/gdb.base/watch_thread_num.exp
> @@ -60,7 +60,7 @@ gdb_test "continue" ".*Breakpoint .*loop.*" "Stopped in loop"
                                                                 ^^^^^^^^^^^^^^^

and:

>  
>  
>  gdb_test_multiple "thread" "Thread command" {

                               ^^^^^^^^^^^^^^^

>      -re ".*Current thread is (\[0-9\]*).*$gdb_prompt $" {
> -	pass "Thread command" 
> +	pass "thread command" 
>      }
>  }
>  

Thanks,
Pedro Alves