From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56112 invoked by alias); 15 Nov 2016 19:28:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56099 invoked by uid 89); 15 Nov 2016 19:28:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=inconsistencies, ust, adopt, policy X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Nov 2016 19:28:02 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92CF2A73A5; Tue, 15 Nov 2016 19:28:01 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAFJS0gx028664; Tue, 15 Nov 2016 14:28:00 -0500 Subject: Re: [PATCH, v2] Fixup test names starting with uppercase To: Luis Machado , gdb-patches@sourceware.org References: <1478929984-32339-1-git-send-email-lgustavo@codesourcery.com> From: Pedro Alves Message-ID: <1fe09c2b-e293-f7d3-a004-5659ed4e8160@redhat.com> Date: Tue, 15 Nov 2016 19:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478929984-32339-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00389.txt.bz2 On 11/12/2016 05:53 AM, Luis Machado wrote: > This fixes the offender testcases that have test names starting with > uppercase. > > I also tried to catch cases where we set the test names via variables. > > We should probably adopt a policy and stick with it. If the way to go is > all lowercase, then the following patch should hopefully help clean some > of the inconsistencies up. Otherwise, we should go the other way and adjust > the test names to start with uppercase. I agree with lowercase. It's what we use most pervasively, and I've asked people to lowercase messages in review in the past. The fewer (bad) examples people can crib from, the better. So thanks for doing this. > > There is also the question about capitalization of architecture names, > technology names (UST, TE) and language names (Pascal/Python/Rust). I think all those are fine to capitalize. > - unsupported "ARM NEON is not supported" > + unsupported "arm NEON is not supported" (If we lowercased arm, why not neon?) Likewise, I think ABI, GDB, MI, CLI, PowerPC, LZMA, UST, all lowercased at least once in the patch, sometimes inconsistently, can/should remain uppercase. Also noticed: > --- a/gdb/testsuite/gdb.base/watch_thread_num.exp > +++ b/gdb/testsuite/gdb.base/watch_thread_num.exp > @@ -60,7 +60,7 @@ gdb_test "continue" ".*Breakpoint .*loop.*" "Stopped in loop" ^^^^^^^^^^^^^^^ and: > > > gdb_test_multiple "thread" "Thread command" { ^^^^^^^^^^^^^^^ > -re ".*Current thread is (\[0-9\]*).*$gdb_prompt $" { > - pass "Thread command" > + pass "thread command" > } > } > Thanks, Pedro Alves