From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84578 invoked by alias); 15 Nov 2016 19:52:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84465 invoked by uid 89); 15 Nov 2016 19:52:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=polish, perror, policy X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Nov 2016 19:52:39 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1c6jmX-0003ec-43 from Luis_Gustavo@mentor.com ; Tue, 15 Nov 2016 11:52:37 -0800 Received: from [134.86.105.206] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 15 Nov 2016 11:52:34 -0800 Reply-To: Luis Machado Subject: Re: [PATCH, v2] Fixup test names starting with uppercase References: <1478929984-32339-1-git-send-email-lgustavo@codesourcery.com> <1fe09c2b-e293-f7d3-a004-5659ed4e8160@redhat.com> To: Pedro Alves , From: Luis Machado Message-ID: <2bdcf3fe-3606-b5fb-f71d-d2fac437b81b@codesourcery.com> Date: Tue, 15 Nov 2016 19:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1fe09c2b-e293-f7d3-a004-5659ed4e8160@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00391.txt.bz2 On 11/15/2016 01:28 PM, Pedro Alves wrote: > On 11/12/2016 05:53 AM, Luis Machado wrote: >> This fixes the offender testcases that have test names starting with >> uppercase. >> >> I also tried to catch cases where we set the test names via variables. >> >> We should probably adopt a policy and stick with it. If the way to go is >> all lowercase, then the following patch should hopefully help clean some >> of the inconsistencies up. Otherwise, we should go the other way and adjust >> the test names to start with uppercase. > > I agree with lowercase. It's what we use most pervasively, and I've > asked people to lowercase messages in review in the past. The fewer > (bad) examples people can crib from, the better. So thanks for doing this. > Great. I'll polish the regular expression and i'll try to catch more offenders. While at it, do we also want to lowercase debugging messages emitted from perror/error/warning/verbose etc? I could do that in a separate patch.