From: John Baldwin <jhb@FreeBSD.org>
To: Enze Li <enze.li@hotmail.com>, gdb-patches@sourceware.org
Cc: enze.li@gmx.com
Subject: Re: [PATCH v2] gdb/amd64: clean up unused variable
Date: Tue, 2 Aug 2022 08:44:28 -0700 [thread overview]
Message-ID: <2a2ccf3e-503f-96e8-8b8b-18a1b98fb93c@FreeBSD.org> (raw)
In-Reply-To: <OS3P286MB21529366F90E321BD61DEE4CF09A9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM>
On 8/1/22 3:23 PM, Enze Li wrote:
> When building with clang 15, I got this,
>
> CXX amd64-tdep.o
> amd64-tdep.c:1410:13: error: variable 'insn' set but not used[-Werror,-Wunused-but-set-variable]
> gdb_byte *insn = insn_details->raw_insn + modrm_offset;
> ^
> 1 error generated.
>
> The function that uses this variable has been removed in this commit,
LGTM, and I think this is obvious enough you can push it.
--
John Baldwin
next prev parent reply other threads:[~2022-08-02 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 4:14 [PATCH] " Enze Li via Gdb-patches
2022-08-01 17:55 ` John Baldwin
2022-08-01 22:23 ` [PATCH v2] " Enze Li via Gdb-patches
2022-08-02 15:44 ` John Baldwin [this message]
2022-08-03 12:30 ` Enze Li via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2ccf3e-503f-96e8-8b8b-18a1b98fb93c@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=enze.li@gmx.com \
--cc=enze.li@hotmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox