From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Q8YfJ39G6WKCKR8AWB0awg (envelope-from ) for ; Tue, 02 Aug 2022 11:45:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 92E7D1EA05; Tue, 2 Aug 2022 11:45:03 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=EIs84kM4; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 02D7B1EA03 for ; Tue, 2 Aug 2022 11:45:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7628838582A7 for ; Tue, 2 Aug 2022 15:45:02 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 7E6D83857C6C for ; Tue, 2 Aug 2022 15:44:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E6D83857C6C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Lxznv0mS2z4FS6; Tue, 2 Aug 2022 15:44:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lxznv02bCz3knb; Tue, 2 Aug 2022 15:44:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659455091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2CTpj85KqYb4t0/Nz8JrAPGuNMbdNTxJugCXK7o4jYQ=; b=EIs84kM4uSOWLuXYImfdruIJQ2CcUM/LELRng5hfkGcJCJugpYuwMP/iKyTTFa9EgO+78e gUXUBiKV5kefxbTgmlORchmAn/4anhSYakEo87vjHZM+wORm0jHUUbL5SKle9m8mNW2vSV KD9bxicsBUuGDmNImqMqh9xOLkiXaS+oGbFSoTZChSS517e4shJ59vrq3Qmhq6q9ThjQ0B z6HLtQgpm5RRlqsWGDNxmdU3uiIRRBZVRieL3eFvMVfU+v5lAgW17SCq2HQGXISk79yYUq Xiia1ozgCUssbH0GvdblKTFCtOnfM7np+TY2zxtdwSYzb8v2plh/Caw5M0o1Ug== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4LxznV3vZLz1RFF; Tue, 2 Aug 2022 15:44:30 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <2a2ccf3e-503f-96e8-8b8b-18a1b98fb93c@FreeBSD.org> Date: Tue, 2 Aug 2022 08:44:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] gdb/amd64: clean up unused variable Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org References: From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659455091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2CTpj85KqYb4t0/Nz8JrAPGuNMbdNTxJugCXK7o4jYQ=; b=PbJTkVW5z4pfAclI+wOrMKjWEiRBmYfTMnZfKRifs0HySKymDwJ9udvGZtPMmjByOs44uX Evxo/CygI85M6uHKKKGQH2uiopzDu+7D+tPTpyIsgW5+jwlFwZX55y865YGwg7NHN7w8gp AF0FJQ3zY9QRLgdZtJdhbbc4iNqEenZKtBHwWkA9YeWGQBC/lj9lZE8+5u+pqE+XwuXqTB XcMEj4Y0s44n2E3WjlPXvNRdeFDmyPkp5t2FNzgY6i+gc2B4g84G3wKDSH2VZsw904GuzS 2Dv81iDVjHWcYyTjskZLUdzD+EyiA/7drTRsjhVgNIMBYWJiLTWsD+EIckLDuA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659455091; a=rsa-sha256; cv=none; b=mFvyncLrq80djVgwTTayL3FZojuCbIAZwcFVfiJQEStk07F5ZnXUi6h/gcVnPsiZ6uzVWr ZQnlfVL/GMU0UwXD8kFz7KIsnMCnkdGgxim4/AGUl1vajQWwm6MUxTUwBG+Bh/57bfsUVC xqokC074i2tuchIZKe2qoL3Rp+UFe6sVAzh/sC7Z5xZ+BNG1lLJSLKed4iyNO3w9RNi8Xx TKiWbfllEVOOcFy7/1DVGUbxXPQndk+1+RMuH7h+3a0rr74Y0q+u0vx2T/r0F+1vmvjoZx emBdTMal055i314gYcCwLZXQrjggDihmffuTkEoRzdKqETbA6sSWp1l1uVsqKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: enze.li@gmx.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 8/1/22 3:23 PM, Enze Li wrote: > When building with clang 15, I got this, > > CXX amd64-tdep.o > amd64-tdep.c:1410:13: error: variable 'insn' set but not used[-Werror,-Wunused-but-set-variable] > gdb_byte *insn = insn_details->raw_insn + modrm_offset; > ^ > 1 error generated. > > The function that uses this variable has been removed in this commit, LGTM, and I think this is obvious enough you can push it. -- John Baldwin