From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Cc: enze.li@gmx.com
Subject: Re: [PATCH v2] gdb/amd64: clean up unused variable
Date: Wed, 03 Aug 2022 20:30:59 +0800 [thread overview]
Message-ID: <OS3P286MB2152156C34FB618397008BA2F09C9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <2a2ccf3e-503f-96e8-8b8b-18a1b98fb93c@FreeBSD.org>
On Tue, 2022-08-02 at 08:44 -0700, John Baldwin wrote:
> On 8/1/22 3:23 PM, Enze Li wrote:
> > When building with clang 15, I got this,
> >
> > CXX amd64-tdep.o
> > amd64-tdep.c:1410:13: error: variable 'insn' set but not used[-
> > Werror,-Wunused-but-set-variable]
> > gdb_byte *insn = insn_details->raw_insn + modrm_offset;
> > ^
> > 1 error generated.
> >
> > The function that uses this variable has been removed in this
> > commit,
>
> LGTM, and I think this is obvious enough you can push it.
>
Thanks, John. Pushed.
Enze
prev parent reply other threads:[~2022-08-03 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 4:14 [PATCH] " Enze Li via Gdb-patches
2022-08-01 17:55 ` John Baldwin
2022-08-01 22:23 ` [PATCH v2] " Enze Li via Gdb-patches
2022-08-02 15:44 ` John Baldwin
2022-08-03 12:30 ` Enze Li via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB2152156C34FB618397008BA2F09C9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
--to=gdb-patches@sourceware.org \
--cc=enze.li@gmx.com \
--cc=enze.li@hotmail.com \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox