Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Volkov <Andrew.Volkov@transas.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com, jimb@redhat.com, ezannoni@redhat.com
Subject: RE: [RFA/RFC] blockframe.c Fix errorneous addr check
Date: Thu, 27 Jun 2002 11:08:00 -0000	[thread overview]
Message-ID: <2E74F312D6980D459F3A05492BA40F8DFE33AA@clue.transas.com> (raw)

>On Thu, Jun 27, 2002 at 09:13:41PM +0400, Andrew Volkov wrote:
>> Hi,
>> 
>> This patch fix wrong detection of belonging addr to startup file:
>> if call main is last instuction in crt0, then 
>> inside_entry_file erroneously return false.
>> 
>> Ok to commit?
>> Andrey 
>> 
>> P.S. Possible this bug not in this func, but in symbol reader.
>
>I'm inclined to believe the bug is in the symbol reader.  Upper PC
>bounds are generally exclusive - first address after the function.
>
>-- 
>Daniel Jacobowitz                           Carnegie Mellon University
>MontaVista Software                         Debian GNU/Linux Developer
>

Daniel you're right, this bug in coffread.c(complete_symtab) function,
rather, in invalid calculating of current_source_end_addr:

	current_source_end_addr = start_addr + size;

but must be:

	current_source_end_addr = start_addr + size + <addr sizeof>;

As I understand, since machine address size is not known at time of parsing 
coff file, then we have big trouble :(.

Comments/suggestions?

Andrey


             reply	other threads:[~2002-06-27 18:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-27 11:08 Andrew Volkov [this message]
2002-06-27 11:39 ` Kevin Buettner
  -- strict thread matches above, loose matches on Subject: below --
2002-06-28  1:41 Andrew Volkov
2002-06-28  9:26 ` Kevin Buettner
2002-06-27 11:58 Andrew Volkov
2002-06-27 12:18 ` Kevin Buettner
2002-06-27 10:13 Andrew Volkov
2002-06-27 10:18 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2E74F312D6980D459F3A05492BA40F8DFE33AA@clue.transas.com \
    --to=andrew.volkov@transas.com \
    --cc=drow@mvista.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox