From: Andrew Volkov <Andrew.Volkov@transas.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: RE: [RFA/RFC] blockframe.c Fix errorneous addr check
Date: Fri, 28 Jun 2002 01:41:00 -0000 [thread overview]
Message-ID: <2E74F312D6980D459F3A05492BA40F8D0101CF84@clue.transas.com> (raw)
>On Jun 27, 10:58pm, Andrew Volkov wrote:
>
>> >> current_source_end_addr = start_addr + size;
>> >>
>> >> but must be:
>> >>
>> >> current_source_end_addr = start_addr + size + <addr sizeof>;
>> >>
>> >> As I understand, since machine address size is not known at
>> >time of parsing
>> >> coff file, then we have big trouble :(.
>> >
>> >Could you explain why you need to add in the size of an address?
>>
>> It's not necessarily must be addr sizeof, it may be 1, but, I think,
>> will be better, if current_source_end_addr will contain correct
>> value for target.
>
>What I'd like to understand is why (start_addr + size) is insufficient.
>I.e, why do we need to add 1 or some other small value to compute the
>correct ending address?
>
>Kevin
Because start_addr + size is last_addr in block, hence all gdb parts, wich
assume that highpc is first addr after block, will work improperly.
Ex. this check always failed:
if (addr >= lowpc && addr < highpc)
....
when addr = last_addr_in_block.
While I bump with this problem when work with h8300 coff file.
Andrey
next reply other threads:[~2002-06-28 8:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-28 1:41 Andrew Volkov [this message]
2002-06-28 9:26 ` Kevin Buettner
-- strict thread matches above, loose matches on Subject: below --
2002-06-27 11:58 Andrew Volkov
2002-06-27 12:18 ` Kevin Buettner
2002-06-27 11:08 Andrew Volkov
2002-06-27 11:39 ` Kevin Buettner
2002-06-27 10:13 Andrew Volkov
2002-06-27 10:18 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E74F312D6980D459F3A05492BA40F8D0101CF84@clue.transas.com \
--to=andrew.volkov@transas.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox