From: Andrew Volkov <Andrew.Volkov@transas.com>
To: gdb-patches@sources.redhat.com
Cc: jimb@redhat.com, ezannoni@redhat.com
Subject: [RFA/RFC] blockframe.c Fix errorneous addr check
Date: Thu, 27 Jun 2002 10:13:00 -0000 [thread overview]
Message-ID: <2E74F312D6980D459F3A05492BA40F8DFE339D@clue.transas.com> (raw)
Hi,
This patch fix wrong detection of belonging addr to startup file:
if call main is last instuction in crt0, then
inside_entry_file erroneously return false.
Ok to commit?
Andrey
P.S. Possible this bug not in this func, but in symbol reader.
2002-06-27 Andrey Volkov <avolkov@transas.com>
*blockframe.c (inside_entry_file): Fixed erroneous check that
addr is in startup file.
Index: blockframe.c
===================================================================
RCS file: /cvs/src/src/gdb/blockframe.c,v
retrieving revision 1.30
diff -u -r1.30 blockframe.c
--- blockframe.c 26 Jun 2002 15:28:46 -0000 1.30
+++ blockframe.c 27 Jun 2002 16:33:10 -0000
@@ -113,7 +113,7 @@
return 0;
}
return (addr >= symfile_objfile->ei.entry_file_lowpc &&
- addr < symfile_objfile->ei.entry_file_highpc);
+ addr <= symfile_objfile->ei.entry_file_highpc);
}
/* Test a specified PC value to see if it is in the range of addresses
next reply other threads:[~2002-06-27 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-27 10:13 Andrew Volkov [this message]
2002-06-27 10:18 ` Daniel Jacobowitz
2002-06-27 11:08 Andrew Volkov
2002-06-27 11:39 ` Kevin Buettner
2002-06-27 11:58 Andrew Volkov
2002-06-27 12:18 ` Kevin Buettner
2002-06-28 1:41 Andrew Volkov
2002-06-28 9:26 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E74F312D6980D459F3A05492BA40F8DFE339D@clue.transas.com \
--to=andrew.volkov@transas.com \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox