From: "Eli Zaretskii" <eliz@elta.co.il>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: drow@mvista.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Patch for ia64-tdep.c to cross-compile
Date: Tue, 10 Feb 2004 19:09:00 -0000 [thread overview]
Message-ID: <2719-Tue10Feb2004210935+0200-eliz@elta.co.il> (raw)
In-Reply-To: <40292337.3090907@redhat.com> (message from Jeff Johnston on Tue, 10 Feb 2004 13:30:15 -0500)
> Date: Tue, 10 Feb 2004 13:30:15 -0500
> From: Jeff Johnston <jjohnstn@redhat.com>
> >
> > If this is an obvious patch, shouldn't we have some coding rule
> > somewhere to cover it? It certainly isn't obvious out of the GDB
> > context, i.e. not a standard coding practice.
>
> Eli,
>
> Do you want me to hold off on checking this in or do you just wish to discuss
> whether such a patch should be marked as obvious in the future?
I don't think you need to hold off; sorry that I wasn't more clear.
What I wanted to discuss is whether we need to put some text somewhere
that includes the use of paddr* functions in the GDB coding standards.
Then it would be clear that fixing any deviation from that falls under
the obvious fix rule.
next prev parent reply other threads:[~2004-02-10 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 0:15 Jeff Johnston
2004-02-10 2:55 ` Daniel Jacobowitz
2004-02-10 6:23 ` Eli Zaretskii
2004-02-10 18:30 ` Jeff Johnston
2004-02-10 19:09 ` Eli Zaretskii [this message]
2004-02-10 19:37 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2719-Tue10Feb2004210935+0200-eliz@elta.co.il \
--to=eliz@elta.co.il \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox