Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@elta.co.il>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Patch for ia64-tdep.c to cross-compile
Date: Tue, 10 Feb 2004 06:23:00 -0000	[thread overview]
Message-ID: <ullnbzc0y.fsf@elta.co.il> (raw)
In-Reply-To: <20040210025527.GA16979@nevyn.them.org> (message from Daniel Jacobowitz on Mon, 9 Feb 2004 21:55:27 -0500)

> Date: Mon, 9 Feb 2004 21:55:27 -0500
> From: Daniel Jacobowitz <drow@mvista.com>
> > 
> > 2004-02-09  Jeff Johnston  <jjohnstn@redhat.com>
> > 
> >         * ia64-tdep.c (ia64_frame_this_id): Fix tracing print statement
> >         to use paddr functions to format ia64 addresses and long values..
> >         (ia64_frame_prev_register, ia64_sigtramp_frame_this_id): Ditto.
> >         (ia64_sigtramp_frame_prev_register, ia64_access_reg): Ditto.
> >         (get_kernel_table, ia64_find_proc_info_x): Ditto.
> >         (ia64_get_dyn_info_list, ia64_libunwind_this_frame_id): Ditto.
> >         (ia64_libunwind_frame_prev_register, ia64_unwind_dummy_id): Ditto.
> > 
> 
> I think this patch is "obvious"

If this is an obvious patch, shouldn't we have some coding rule
somewhere to cover it?  It certainly isn't obvious out of the GDB
context, i.e. not a standard coding practice.


  reply	other threads:[~2004-02-10  6:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-10  0:15 Jeff Johnston
2004-02-10  2:55 ` Daniel Jacobowitz
2004-02-10  6:23   ` Eli Zaretskii [this message]
2004-02-10 18:30     ` Jeff Johnston
2004-02-10 19:09       ` Eli Zaretskii
2004-02-10 19:37         ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ullnbzc0y.fsf@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox