Re: [RFA]: Patch for ia64-tdep.c to cross-compile

Jeff Johnston
2004-02-10T18:30:17Z

Eli Zaretskii wrote:
>>Date: Mon, 9 Feb 2004 21:55:27 -0500
>>From: Daniel Jacobowitz <drow@mvista.com>
>>
>>>2004-02-09 Jeff Johnston <jjohnstn@redhat.com>
>>>
>>> * ia64-tdep.c (ia64_frame_this_id): Fix tracing print statement
>>> to use paddr functions to format ia64 addresses and long values..
>>> (ia64_frame_prev_register, ia64_sigtramp_frame_this_id): Ditto.
>>> (ia64_sigtramp_frame_prev_register, ia64_access_reg): Ditto.
>>> (get_kernel_table, ia64_find_proc_info_x): Ditto.
>>> (ia64_get_dyn_info_list, ia64_libunwind_this_frame_id): Ditto.
>>> (ia64_libunwind_frame_prev_register, ia64_unwind_dummy_id): Ditto.
>>>
>>
>>I think this patch is "obvious"
>
>
> If this is an obvious patch, shouldn't we have some coding rule
> somewhere to cover it? It certainly isn't obvious out of the GDB
> context, i.e. not a standard coding practice.
>
>

Eli,

Do you want me to hold off on checking this in or do you just wish to discuss
whether such a patch should be marked as obvious in the future?

-- Jeff J.