Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Add two new OS ABI variants
@ 2002-06-09  8:13 Mark Kettenis
  2002-06-09  9:40 ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Kettenis @ 2002-06-09  8:13 UTC (permalink / raw)
  To: gdb-patches

As a preparation for my i386 multi-arch work, this patch adds
GDB_OS_GO32 and GDB_OS_NETWARE (DJGPP, and Novell Netware) and
documents them.

Checked in.

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* osabi.h (gdb_osabi): Add GDB_OSABI_GO32 and GDB_OSABI_NETWARE.
	* osabi.c (gdb_osabi_names): Add "DJGPP" and "NetWare".

Index: doc/ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* gdbint.texinfo (Target Architecture Definition): Document
	GDB_OSABI_GO32 and GDB_OSABI_NETWARE.

Index: osabi.c
===================================================================
RCS file: /cvs/src/src/gdb/osabi.c,v
retrieving revision 1.1
diff -u -p -r1.1 osabi.c
--- osabi.c 21 May 2002 15:36:02 -0000 1.1
+++ osabi.c 9 Jun 2002 15:08:19 -0000
@@ -40,6 +40,8 @@ static const char * const gdb_osabi_name
   "NetBSD a.out",
   "NetBSD ELF",
   "Windows CE",
+  "DJGPP",
+  "NetWare",
 
   "ARM EABI v1",
   "ARM EABI v2",
Index: osabi.h
===================================================================
RCS file: /cvs/src/src/gdb/osabi.h,v
retrieving revision 1.1
diff -u -p -r1.1 osabi.h
--- osabi.h 21 May 2002 15:36:02 -0000 1.1
+++ osabi.h 9 Jun 2002 15:08:19 -0000
@@ -37,6 +37,8 @@ enum gdb_osabi
   GDB_OSABI_NETBSD_AOUT,
   GDB_OSABI_NETBSD_ELF,
   GDB_OSABI_WINCE,
+  GDB_OSABI_GO32,
+  GDB_OSABI_NETWARE,
 
   GDB_OSABI_ARM_EABI_V1,
   GDB_OSABI_ARM_EABI_V2,
Index: doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.89
diff -u -p -r1.89 gdbint.texinfo
--- doc/gdbint.texinfo 9 Jun 2002 02:11:12 -0000 1.89
+++ doc/gdbint.texinfo 9 Jun 2002 15:08:26 -0000
@@ -2386,6 +2386,14 @@ NetBSD using the ELF executable format
 @item GDB_OSABI_WINCE
 Windows CE
 
+@findex GDB_OSABI_GO32
+@item GDB_OSABI_GO32
+DJGPP
+
+@findex GDB_OSABI_NETWARE
+@item GDB_OSABI_NETWARE
+Novell NetWare
+
 @findex GDB_OSABI_ARM_EABI_V1
 @item GDB_OSABI_ARM_EABI_V1
 ARM Embedded ABI version 1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add two new OS ABI variants
  2002-06-09  8:13 [PATCH] Add two new OS ABI variants Mark Kettenis
@ 2002-06-09  9:40 ` Eli Zaretskii
  2002-06-09  9:51   ` Mark Kettenis
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2002-06-09  9:40 UTC (permalink / raw)
  To: kettenis; +Cc: gdb-patches, dj

> Date: Sun, 9 Jun 2002 17:13:28 +0200 (CEST)
> From: Mark Kettenis <kettenis@chello.nl>
> 
> As a preparation for my i386 multi-arch work, this patch adds
> GDB_OS_GO32 and GDB_OS_NETWARE (DJGPP, and Novell Netware) and
> documents them.

Please call the DJGPP architecture GDB_OSABI_DJGPP.  I think it's high
time we forgot the "go32" thing.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add two new OS ABI variants
  2002-06-09  9:40 ` Eli Zaretskii
@ 2002-06-09  9:51   ` Mark Kettenis
  2002-06-09 10:10     ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Kettenis @ 2002-06-09  9:51 UTC (permalink / raw)
  To: eliz; +Cc: gdb-patches, dj

   Date: Sun, 09 Jun 2002 19:39:22 +0300
   From: "Eli Zaretskii" <eliz@is.elta.co.il>

   > Date: Sun, 9 Jun 2002 17:13:28 +0200 (CEST)
   > From: Mark Kettenis <kettenis@chello.nl>
   > 
   > As a preparation for my i386 multi-arch work, this patch adds
   > GDB_OS_GO32 and GDB_OS_NETWARE (DJGPP, and Novell Netware) and
   > documents them.

   Please call the DJGPP architecture GDB_OSABI_DJGPP.  I think it's high
   time we forgot the "go32" thing.

Oh dear, I should have asked for comments first :-).  But does it make
sense to use GDB_OSABI_DJGPP when all function names still use go32
somewhere in their name?  Do you have any plans for renaming those?
Otherwise I think we should keep GDB_OSABI_GO32.  Note that the user
only ever sees "DJGPP" as the name of the target anyway.

Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add two new OS ABI variants
  2002-06-09  9:51   ` Mark Kettenis
@ 2002-06-09 10:10     ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2002-06-09 10:10 UTC (permalink / raw)
  To: kettenis; +Cc: gdb-patches, dj

> Date: Sun, 9 Jun 2002 18:51:45 +0200 (CEST)
> From: Mark Kettenis <kettenis@chello.nl>
> 
> But does it make
> sense to use GDB_OSABI_DJGPP when all function names still use go32
> somewhere in their name?  Do you have any plans for renaming those?

I don't mind renaming go32-nat.c into djgpp-nat.c, but renaming a
file in CVS has nasty side effects, and I'm not sure we have a reason
good enough to suffer those side effects.

But a new constant, if we name it DJGPP from day one, has no such
adverse consequences.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-06-09 17:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-06-09  8:13 [PATCH] Add two new OS ABI variants Mark Kettenis
2002-06-09  9:40 ` Eli Zaretskii
2002-06-09  9:51   ` Mark Kettenis
2002-06-09 10:10     ` Eli Zaretskii

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox