From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Manish Goregaokar <manish@mozilla.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work
Date: Wed, 29 Jun 2016 09:15:00 -0000 [thread overview]
Message-ID: <2222194.RiloiX1RyX@e108577-lin> (raw)
In-Reply-To: <CAFOnWk=c4PxeagbKO3z2i4uMUPfb_-FVbFh0B4QZMC1aoMUWZA@mail.gmail.com>
On Wednesday 29 June 2016 14:27:56 Manish Goregaokar wrote:
> No, strsep was just a better fit here. I wasn't aware that it doesn't
> work on windows.
I just found it when investigating the build failure: the manual says it
conforms to 4.4BSD and suggest the use of strtok for portability.
>
> I'll fix it to use strtok.
Great, many thanks! While you are at it, shouldn't an include of string.h be
added as well? It clearly does not fail now without it because I suppose
another header is including it.
Best regards,
Thomas
next prev parent reply other threads:[~2016-06-29 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFOnWknif9WwaRdDYzxx8ngNJBwgfN24w02KGPVnYA6-VtMcUg@mail.gmail.com>
2016-06-22 19:10 ` Tom Tromey
2016-06-25 6:00 ` Manish Goregaokar
2016-06-29 8:55 ` Thomas Preudhomme
2016-06-29 8:58 ` Manish Goregaokar
2016-06-29 9:15 ` Thomas Preudhomme [this message]
2016-06-29 9:17 ` Manish Goregaokar
2016-06-29 9:19 ` Thomas Preudhomme
2016-06-29 9:41 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2222194.RiloiX1RyX@e108577-lin \
--to=thomas.preudhomme@foss.arm.com \
--cc=gdb-patches@sourceware.org \
--cc=manish@mozilla.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox