From: Pedro Alves <palves@redhat.com>
To: Manish Goregaokar <manish@mozilla.com>,
Thomas Preudhomme <thomas.preudhomme@foss.arm.com>,
gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work
Date: Wed, 29 Jun 2016 09:41:00 -0000 [thread overview]
Message-ID: <08a5da9e-784d-04cb-3ab3-b0a82751d7fa@redhat.com> (raw)
In-Reply-To: <CAFOnWk=c4PxeagbKO3z2i4uMUPfb_-FVbFh0B4QZMC1aoMUWZA@mail.gmail.com>
On 06/29/2016 09:57 AM, Manish Goregaokar wrote:
> No, strsep was just a better fit here. I wasn't aware that it doesn't
> work on windows.
>
> I'll fix it to use strtok.
You can use strtok_r. We pull the gnulib module that ensures it's
always available.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-06-29 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFOnWknif9WwaRdDYzxx8ngNJBwgfN24w02KGPVnYA6-VtMcUg@mail.gmail.com>
2016-06-22 19:10 ` Tom Tromey
2016-06-25 6:00 ` Manish Goregaokar
2016-06-29 8:55 ` Thomas Preudhomme
2016-06-29 8:58 ` Manish Goregaokar
2016-06-29 9:15 ` Thomas Preudhomme
2016-06-29 9:17 ` Manish Goregaokar
2016-06-29 9:19 ` Thomas Preudhomme
2016-06-29 9:41 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08a5da9e-784d-04cb-3ab3-b0a82751d7fa@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=manish@mozilla.com \
--cc=thomas.preudhomme@foss.arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox