From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118410 invoked by alias); 29 Jun 2016 09:41:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118309 invoked by uid 89); 29 Jun 2016 09:41:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jun 2016 09:41:16 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A037B745; Wed, 29 Jun 2016 09:41:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5T9fCm1019136; Wed, 29 Jun 2016 05:41:13 -0400 Subject: Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work To: Manish Goregaokar , Thomas Preudhomme , gdb-patches@sourceware.org, Tom Tromey References: <5013369.B1hQpEVniv@e108577-lin> From: Pedro Alves Message-ID: <08a5da9e-784d-04cb-3ab3-b0a82751d7fa@redhat.com> Date: Wed, 29 Jun 2016 09:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00495.txt.bz2 On 06/29/2016 09:57 AM, Manish Goregaokar wrote: > No, strsep was just a better fit here. I wasn't aware that it doesn't > work on windows. > > I'll fix it to use strtok. You can use strtok_r. We pull the gnulib module that ensures it's always available. Thanks, Pedro Alves