From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94497 invoked by alias); 29 Jun 2016 09:15:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94452 invoked by uid 89); 29 Jun 2016 09:15:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Jun 2016 09:15:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3394A2F; Wed, 29 Jun 2016 02:16:19 -0700 (PDT) Received: from e108577-lin.localnet (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 29B893F246; Wed, 29 Jun 2016 02:15:26 -0700 (PDT) From: Thomas Preudhomme To: Manish Goregaokar Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work Date: Wed, 29 Jun 2016 09:15:00 -0000 Message-ID: <2222194.RiloiX1RyX@e108577-lin> User-Agent: KMail/4.13.3 (Linux/3.13.0-85-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <5013369.B1hQpEVniv@e108577-lin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00491.txt.bz2 On Wednesday 29 June 2016 14:27:56 Manish Goregaokar wrote: > No, strsep was just a better fit here. I wasn't aware that it doesn't > work on windows. I just found it when investigating the build failure: the manual says it conforms to 4.4BSD and suggest the use of strtok for portability. > > I'll fix it to use strtok. Great, many thanks! While you are at it, shouldn't an include of string.h be added as well? It clearly does not fail now without it because I suppose another header is including it. Best regards, Thomas