Re: [PATCH v2] Python API: Fix an exception when registering a global pretty-printer in verbose mode

[Doug Evans <dje@google.com>]

Martin Galvan writes:
 > This patch fixes a Python exception that was being thrown when trying to register a global pretty-printer with verbose mode on:
 > 
 >   File "/usr/share/gdb/python/gdb/printing.py", line 119, in register_pretty_printer
 >     gdb.write("Registering global %s pretty-printer ...\n" % name)
 > NameError: name 'name' is not defined
 > 
 > My copyright assignment is on the works, but since this is a small patch I don't think it's necessary.
 > 
 > Changes from v1:
 >  * Moved printer.name to the next line so that it won't break the 80 character limit.
 > 
 > --
 > 
 > Changelog:
 > 
 > 2015-03-11  Martin Galvan  <martin.galvan@tallertechnologies.com>
 > 
 > 	* python/lib/gdb/printing.py: Fix exception when registering a global pretty-printer in verbose mode.
 > 
 > diff --git a/gdb/python/lib/gdb/printing.py b/gdb2/python/lib/gdb/printing.py
 > index 47742a9..c935333 100644
 > --- a/gdb/python/lib/gdb/printing.py
 > +++ b/gdb/python/lib/gdb/printing.py
 > @@ -116,7 +116,8 @@ def register_pretty_printer(obj, printer, replace=False):
 > 
 >      if obj is None:
 >          if gdb.parameter("verbose"):
 > -            gdb.write("Registering global %s pretty-printer ...\n" % name)
 > +            gdb.write("Registering global %s pretty-printer ...\n" %
 > +                      printer.name)
 >          obj = gdb
 >      else:
 >          if gdb.parameter("verbose"):

LGTM, with two more nits.
The ChangeLog entry > 80 char limit :-),
and convention is to include the function name in the ChangeLog entry.

E.g.,

2015-03-11  Martin Galvan  <martin.galvan@tallertechnologies.com>

	* python/lib/gdb/printing.py (register_pretty_printer): Fix exception
	when registering a global pretty-printer in verbose mode.

No need to repost though.
Ok to commit with that fixed.