From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55643 invoked by alias); 11 Mar 2015 23:52:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55631 invoked by uid 89); 11 Mar 2015 23:52:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ig0-f202.google.com Received: from mail-ig0-f202.google.com (HELO mail-ig0-f202.google.com) (209.85.213.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Mar 2015 23:52:41 +0000 Received: by igkb16 with SMTP id b16so3609344igk.0 for ; Wed, 11 Mar 2015 16:52:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=JSJOgbOJpkro9Jb3OzgIbKxS33Vlm9pPYR5b9I9oqoo=; b=mH4QKPejSV4CvuPJqi3bVL9efgg9xFImolT1ITX3hI6HJSJzOrdC+/UsCYkkieQ7O1 OVrlqaqtgCuDhwWo+O65sS3SBdTXVwcvCZHUNoDueVsiijP0WVTVWu0NpdBgiljh1DSD Stx4+5W7cJ4bybHfZ71AZmyeQ468y+CHBYPVdxqDDFP02l0YY1nSFuQ4ojqv6X9kteQc 4o1tye8g7TxehNDNEf0yVnKfCrs7C0czfFwy43aPm8pgQ3ZuNdwndE/0UZHYFVd84k4n yCfMDzIs5fCkEjZZfJhtm+UzrpeEVwZeF4QtAhoaJY5X2OAj8HeSuSzUO2or6S9fT8jC jQ2w== X-Gm-Message-State: ALoCoQmAsJPmFh6ZXWinplJfbcWewE9yWIekhqjWzD1bc2L/dyTMZyByEfnMQhWlN6aJWknmZaiaUe6Zpi3Bp8e4zP4BxskHDlr8XxBlV4s41cxgtoK89XLQAuJeX95hs/mSpW8CoCg0hIW3/5TnVzVl0BfcvMFCo4vX2es1Pl5tpE8A2F7blrI= X-Received: by 10.182.176.35 with SMTP id cf3mr39155300obc.8.1426117959255; Wed, 11 Mar 2015 16:52:39 -0700 (PDT) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id l2si124853yhg.7.2015.03.11.16.52.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Mar 2015 16:52:39 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTP id kuivli3A.1; Wed, 11 Mar 2015 16:52:39 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21760.54598.126480.383468@ruffy2.mtv.corp.google.com> Date: Wed, 11 Mar 2015 23:52:00 -0000 To: Martin Galvan Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Python API: Fix an exception when registering a global pretty-printer in verbose mode In-Reply-To: <1426097817-30955-1-git-send-email-martin.galvan@tallertechnologies.com> References: <1426097817-30955-1-git-send-email-martin.galvan@tallertechnologies.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00327.txt.bz2 Martin Galvan writes: > This patch fixes a Python exception that was being thrown when trying to register a global pretty-printer with verbose mode on: > > File "/usr/share/gdb/python/gdb/printing.py", line 119, in register_pretty_printer > gdb.write("Registering global %s pretty-printer ...\n" % name) > NameError: name 'name' is not defined > > My copyright assignment is on the works, but since this is a small patch I don't think it's necessary. > > Changes from v1: > * Moved printer.name to the next line so that it won't break the 80 character limit. > > -- > > Changelog: > > 2015-03-11 Martin Galvan > > * python/lib/gdb/printing.py: Fix exception when registering a global pretty-printer in verbose mode. > > diff --git a/gdb/python/lib/gdb/printing.py b/gdb2/python/lib/gdb/printing.py > index 47742a9..c935333 100644 > --- a/gdb/python/lib/gdb/printing.py > +++ b/gdb/python/lib/gdb/printing.py > @@ -116,7 +116,8 @@ def register_pretty_printer(obj, printer, replace=False): > > if obj is None: > if gdb.parameter("verbose"): > - gdb.write("Registering global %s pretty-printer ...\n" % name) > + gdb.write("Registering global %s pretty-printer ...\n" % > + printer.name) > obj = gdb > else: > if gdb.parameter("verbose"): LGTM, with two more nits. The ChangeLog entry > 80 char limit :-), and convention is to include the function name in the ChangeLog entry. E.g., 2015-03-11 Martin Galvan * python/lib/gdb/printing.py (register_pretty_printer): Fix exception when registering a global pretty-printer in verbose mode. No need to repost though. Ok to commit with that fixed.