From: Martin Galvan <martin.galvan@tallertechnologies.com>
To: gdb-patches@sourceware.org, dje@google.com
Subject: [PATCH v2] Python API: Fix an exception when registering a global pretty-printer in verbose mode
Date: Wed, 11 Mar 2015 18:17:00 -0000 [thread overview]
Message-ID: <1426097817-30955-1-git-send-email-martin.galvan@tallertechnologies.com> (raw)
This patch fixes a Python exception that was being thrown when trying to register a global pretty-printer with verbose mode on:
File "/usr/share/gdb/python/gdb/printing.py", line 119, in register_pretty_printer
gdb.write("Registering global %s pretty-printer ...\n" % name)
NameError: name 'name' is not defined
My copyright assignment is on the works, but since this is a small patch I don't think it's necessary.
Changes from v1:
* Moved printer.name to the next line so that it won't break the 80 character limit.
--
Changelog:
2015-03-11 Martin Galvan <martin.galvan@tallertechnologies.com>
* python/lib/gdb/printing.py: Fix exception when registering a global pretty-printer in verbose mode.
diff --git a/gdb/python/lib/gdb/printing.py b/gdb2/python/lib/gdb/printing.py
index 47742a9..c935333 100644
--- a/gdb/python/lib/gdb/printing.py
+++ b/gdb/python/lib/gdb/printing.py
@@ -116,7 +116,8 @@ def register_pretty_printer(obj, printer, replace=False):
if obj is None:
if gdb.parameter("verbose"):
- gdb.write("Registering global %s pretty-printer ...\n" % name)
+ gdb.write("Registering global %s pretty-printer ...\n" %
+ printer.name)
obj = gdb
else:
if gdb.parameter("verbose"):
next reply other threads:[~2015-03-11 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 18:17 Martin Galvan [this message]
2015-03-11 23:52 ` Doug Evans
2015-03-12 0:25 ` Martin Galvan
2015-03-28 20:40 ` Martin Galvan
2016-01-01 11:33 ` Joel Brobecker
2016-01-02 1:09 ` Martin Galvan
2016-01-02 2:46 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426097817-30955-1-git-send-email-martin.galvan@tallertechnologies.com \
--to=martin.galvan@tallertechnologies.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox