From: Doug Evans <dje@google.com>
To: David Blaikie <dblaikie@gmail.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] add return values to return statements in non-void functions
Date: Thu, 24 Apr 2014 00:23:00 -0000 [thread overview]
Message-ID: <21336.22905.197076.913141@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <CAENS6Ev9CdJBUt9JaFtsroSD=gC3OfnHFYBdd=hPENWGCxv8SA@mail.gmail.com>
David Blaikie writes:
> These missing return values cause build breaks with clang which
> defaults the -Wreturn-type warning to an error in this case.
>
> Add the right return values so these tests can run when using clang.
> commit ce1534e51863af5d935cdc63c44df0fa64a46653
> Author: David Blaikie <dblaikie@gmail.com>
> Date: Fri Apr 11 17:20:49 2014 -0700
>
> Add return value for non-void function return statements to fix error in clang build.
>
> Clang defaults this warning to an error, breaking the build & causing
> these tests not to run.
>
> gdb/testsuite/
>
> * gdb.mi/non-stop.c: Add return value for non-void function return
> statement.
> * gdb.threads/staticthreads.c: Ditto.
ChangeLog rules require being more specific about where the change happened.
E.g.,
* gdb.mi/non-stop.c (worker): Add return value for non-void function
return statement.
* gdb.threads/staticthreads.c (thread_function): Ditto.
Ok with those changes.
Thanks!
next prev parent reply other threads:[~2014-04-24 0:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 0:24 David Blaikie
2014-04-14 13:03 ` Joel Brobecker
2014-04-14 15:38 ` David Blaikie
2014-04-24 0:23 ` Doug Evans [this message]
2014-04-24 0:30 ` Doug Evans
2014-04-24 20:26 ` David Blaikie
2014-04-24 20:32 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21336.22905.197076.913141@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=dblaikie@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox