Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Blaikie <dblaikie@gmail.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: [patch] add return values to return statements in non-void functions
Date: Sat, 12 Apr 2014 00:24:00 -0000	[thread overview]
Message-ID: <CAENS6Ev9CdJBUt9JaFtsroSD=gC3OfnHFYBdd=hPENWGCxv8SA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

These missing return values cause build breaks with clang which
defaults the -Wreturn-type warning to an error in this case.

Add the right return values so these tests can run when using clang.

[-- Attachment #2: missing_return_value.diff --]
[-- Type: text/plain, Size: 1643 bytes --]

commit ce1534e51863af5d935cdc63c44df0fa64a46653
Author: David Blaikie <dblaikie@gmail.com>
Date:   Fri Apr 11 17:20:49 2014 -0700

    Add return value for non-void function return statements to fix error in clang build.
    
    Clang defaults this warning to an error, breaking the build & causing
    these tests not to run.
    
    gdb/testsuite/
    
    	* gdb.mi/non-stop.c: Add return value for non-void function return
    	statement.
    	* gdb.threads/staticthreads.c: Ditto.

diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog
index 12ed4f9..1b26439 100644
--- gdb/testsuite/ChangeLog
+++ gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2014-04-10  David Blaikie <dblaikie@gmail.com>
+
+	* gdb.mi/non-stop.c: Add return value for non-void function return
+	statement.
+	* gdb.threads/staticthreads.c: Ditto.
+
 2014-04-10  Pedro Alves  <palves@redhat.com>
 
 	* gdb.base/cond-eval-mode.c: New file.
diff --git gdb/testsuite/gdb.mi/non-stop.c gdb/testsuite/gdb.mi/non-stop.c
index f03180e..67b68aa 100644
--- gdb/testsuite/gdb.mi/non-stop.c
+++ gdb/testsuite/gdb.mi/non-stop.c
@@ -56,7 +56,7 @@ worker (void *arg)
 	unslept = sleep (unslept);
 
       if (exit_first_thread && id == 0)
-	return;
+	return NULL;
 
       break_at_me (id, i);
     }
diff --git gdb/testsuite/gdb.threads/staticthreads.c gdb/testsuite/gdb.threads/staticthreads.c
index f98f4f1..e834d7f 100644
--- gdb/testsuite/gdb.threads/staticthreads.c
+++ gdb/testsuite/gdb.threads/staticthreads.c
@@ -37,7 +37,7 @@ thread_function (void *arg)
       if (errno != EINTR)
 	{
 	  perror ("thread_function");
-	  return;
+	  return NULL;
 	}
     }
   return NULL;

             reply	other threads:[~2014-04-12  0:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-12  0:24 David Blaikie [this message]
2014-04-14 13:03 ` Joel Brobecker
2014-04-14 15:38   ` David Blaikie
2014-04-24  0:23 ` Doug Evans
2014-04-24  0:30   ` Doug Evans
2014-04-24 20:26     ` David Blaikie
2014-04-24 20:32       ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAENS6Ev9CdJBUt9JaFtsroSD=gC3OfnHFYBdd=hPENWGCxv8SA@mail.gmail.com' \
    --to=dblaikie@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox