From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1993 invoked by alias); 24 Apr 2014 00:23:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1984 invoked by uid 89); 24 Apr 2014 00:23:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f73.google.com Received: from mail-pa0-f73.google.com (HELO mail-pa0-f73.google.com) (209.85.220.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 24 Apr 2014 00:23:24 +0000 Received: by mail-pa0-f73.google.com with SMTP id lj1so93670pab.2 for ; Wed, 23 Apr 2014 17:23:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=RAnmmDllQeFQHMq7MPPJWAYG6SYYbb1s2JCrJUXAsbk=; b=ca6bScUtPu+1oCV3VP9DEXC1h34Z+E+QWtaN2BO6RnfQqTf8rvmRw4FH29KoaNfH56 X7JyAbtE+RmRqpA0Acbd4Zz0F2tGUt976znoBySbr5bJDsumqa+gImEbRsGYGrSIXnFy chIFXOqdmal5r3QKf7mZzGtBt+ltNWGG7jW34AVdusNvpzJKc/Wry6Pd4HFtkM35lVzX 3aS6xXsL45nSm4bjgtsYQp8lf8lFTlzt+FTphTCfylfKTxjormIuJnHQ1BxvpoIj8x2o QhIfra1kqWwvJDrj12UU9VSGbXARYFH5mWEBehQDDLxDi/mmU1uWkJgjATPmRIs83rM0 JiNQ== X-Gm-Message-State: ALoCoQm/Pp4O89ZXUEWYvfwqWfOlJBHGRxIReuX2ZynqZncMDwdWOSW5K/w/jd8+T0xBT0T5DX5SMNYHT3siFxt1luwYM9K/dOrWSyFxgTROHNqHUxQgvA9XZ9q7eIaidBY9ugnE8gv4Hnklm+4A+7WPKQdAYu7qpE75R24p7uZ4RH4SgeMYma2VFuVtQeX/ZBSGd0r6lsq0QCTmOJR825h1orcqNqW5kA== X-Received: by 10.66.102.3 with SMTP id fk3mr614639pab.17.1398299002287; Wed, 23 Apr 2014 17:23:22 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id m50si331614yhk.7.2014.04.23.17.23.22 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Apr 2014 17:23:22 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id B63DF31C1A2; Wed, 23 Apr 2014 17:23:21 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21336.22905.197076.913141@ruffy.mtv.corp.google.com> Date: Thu, 24 Apr 2014 00:23:00 -0000 To: David Blaikie Cc: gdb-patches Subject: Re: [patch] add return values to return statements in non-void functions In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00484.txt.bz2 David Blaikie writes: > These missing return values cause build breaks with clang which > defaults the -Wreturn-type warning to an error in this case. > > Add the right return values so these tests can run when using clang. > commit ce1534e51863af5d935cdc63c44df0fa64a46653 > Author: David Blaikie > Date: Fri Apr 11 17:20:49 2014 -0700 > > Add return value for non-void function return statements to fix error in clang build. > > Clang defaults this warning to an error, breaking the build & causing > these tests not to run. > > gdb/testsuite/ > > * gdb.mi/non-stop.c: Add return value for non-void function return > statement. > * gdb.threads/staticthreads.c: Ditto. ChangeLog rules require being more specific about where the change happened. E.g., * gdb.mi/non-stop.c (worker): Add return value for non-void function return statement. * gdb.threads/staticthreads.c (thread_function): Ditto. Ok with those changes. Thanks!