From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix PR symtab/15597
Date: Thu, 10 Oct 2013 00:17:00 -0000 [thread overview]
Message-ID: <21077.61952.984944.635448@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <87pprfft9c.fsf@fleche.redhat.com>
Tom Tromey writes:
> >>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
>
> Tom> This patch fixes gdb PR symtab/15597.
> Tom> The bug is that the .gnu_debugaltlink section includes the build-id of
> Tom> the alt file, but gdb does not use it.
>
> I'm checking in an updated version of this patch now.
> The only change is to fix the patch for the objfile_name change in gdb.
> I rebuilt and regtested this on x86-64 Fedora 18.
>
> Tom
>
> * bfd-in2.h: Rebuild.
> * opncls.c (bfd_get_alt_debug_link_info): Add buildid_len
> parameter. Change type of buildid_out. Update.
> (get_alt_debug_link_info_shim): New function.
> (bfd_follow_gnu_debuglink): Use it.
>
> * Makefile.in (SFILES): Add build-id.c.
> (HFILES_NO_SRCDIR): Add build-id.h.
> * build-id.c: New file, largely from elfread.c. Modified
> most functions.
> * build-id.h: New file.
> * dwarf2read.c (dwarf2_get_dwz_file): Update for change to
> bfd_get_alt_debug_link_info. Verify dwz file's build-id.
> Search for dwz file using build-id.
> * elfread.c (build_id_bfd_get, build_id_verify)
> (build_id_to_debug_filename, find_separate_debug_file): Remove.
>
> * gdb.dwarf2/dwzbuildid.exp: New file.
> * lib/dwarf.exp (Dwarf::_section): Add "flags" and "type"
> parameters.
> (Dwarf::_defer_output): Change "section" parameter to
> "section_spec"; update.
> (Dwarf::gnu_debugaltlink, Dwarf::_note, Dwarf::build_id): New
> procs.
So code was moved to a different file and edited in one step
(instead of moving it, and then editing it in a separate pass)?
[not that I mind per se, but I thought doing things that way
was more than just "nice to have"]
next prev parent reply other threads:[~2013-10-10 0:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 17:37 Tom Tromey
2013-08-10 5:36 ` Alan Modra
2013-08-12 8:41 ` Tom Tromey
2013-08-12 9:29 ` Alan Modra
2013-08-14 11:25 ` nick clifton
2013-10-08 19:38 ` Tom Tromey
2013-10-08 22:10 ` Hans-Peter Nilsson
2013-10-09 1:27 ` Tom Tromey
2013-10-09 14:09 ` Tom Tromey
2013-10-09 14:54 ` Build regression on 32-bit hosts [Re: [PATCH] fix PR symtab/15597] Jan Kratochvil
2013-10-09 15:46 ` Tom Tromey
2013-10-10 0:17 ` Doug Evans [this message]
2013-10-10 2:29 ` [PATCH] fix PR symtab/15597 Tom Tromey
2013-10-10 19:04 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21077.61952.984944.635448@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox