From: Tom Tromey <tromey@redhat.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] fix PR symtab/15597
Date: Wed, 09 Oct 2013 14:09:00 -0000 [thread overview]
Message-ID: <878uy2edtz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8738obfd3q.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 08 Oct 2013 19:27:05 -0600")
Tom> Sorry about that.
Tom> I'll fix it in the morning.
Here's the fix I am checking in.
Tom
bfd/ChangeLog:
2013-10-09 Tom Tromey <tromey@redhat.com>
* bfd-in2.h: Rebuild.
* opncls.c (bfd_get_alt_debug_link_info): Change type of
buildid_len to bfd_size_type.
gdb/ChangeLog:
2013-10-09 Tom Tromey <tromey@redhat.com>
* dwarf2read.c (dwarf2_get_dwz_file): Update for type change in
bfd_get_alt_debug_link_info.
Index: bfd/bfd-in2.h
===================================================================
RCS file: /cvs/src/src/bfd/bfd-in2.h,v
retrieving revision 1.613
diff -u -r1.613 bfd-in2.h
--- bfd/bfd-in2.h 8 Oct 2013 19:56:14 -0000 1.613
+++ bfd/bfd-in2.h 9 Oct 2013 14:01:57 -0000
@@ -1067,7 +1067,8 @@
char *bfd_get_debug_link_info (bfd *abfd, unsigned long *crc32_out);
-char *bfd_get_alt_debug_link_info (bfd * abfd, size_t *buildid_len,
+char *bfd_get_alt_debug_link_info (bfd * abfd,
+ bfd_size_type *buildid_len,
bfd_byte **buildid_out);
char *bfd_follow_gnu_debuglink (bfd *abfd, const char *dir);
Index: bfd/opncls.c
===================================================================
RCS file: /cvs/src/src/bfd/opncls.c,v
retrieving revision 1.83
diff -u -r1.83 opncls.c
--- bfd/opncls.c 8 Oct 2013 19:56:14 -0000 1.83
+++ bfd/opncls.c 9 Oct 2013 14:01:58 -0000
@@ -1194,7 +1194,8 @@
bfd_get_alt_debug_link_info
SYNOPSIS
- char *bfd_get_alt_debug_link_info (bfd * abfd, size_t *buildid_len,
+ char *bfd_get_alt_debug_link_info (bfd * abfd,
+ bfd_size_type *buildid_len,
bfd_byte **buildid_out);
DESCRIPTION
@@ -1207,7 +1208,7 @@
*/
char *
-bfd_get_alt_debug_link_info (bfd * abfd, size_t *buildid_len,
+bfd_get_alt_debug_link_info (bfd * abfd, bfd_size_type *buildid_len,
bfd_byte **buildid_out)
{
asection *sect;
Index: gdb/dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.842
diff -u -r1.842 dwarf2read.c
--- gdb/dwarf2read.c 8 Oct 2013 19:56:15 -0000 1.842
+++ gdb/dwarf2read.c 9 Oct 2013 14:02:01 -0000
@@ -2365,6 +2365,7 @@
struct cleanup *cleanup;
const char *filename;
struct dwz_file *result;
+ bfd_size_type buildid_len_arg;
size_t buildid_len;
bfd_byte *buildid;
@@ -2373,7 +2374,7 @@
bfd_set_error (bfd_error_no_error);
data = bfd_get_alt_debug_link_info (dwarf2_per_objfile->objfile->obfd,
- &buildid_len, &buildid);
+ &buildid_len_arg, &buildid);
if (data == NULL)
{
if (bfd_get_error () == bfd_error_no_error)
@@ -2384,6 +2385,8 @@
cleanup = make_cleanup (xfree, data);
make_cleanup (xfree, buildid);
+ buildid_len = (size_t) buildid_len_arg;
+
filename = (const char *) data;
if (!IS_ABSOLUTE_PATH (filename))
{
next prev parent reply other threads:[~2013-10-09 14:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 17:37 Tom Tromey
2013-08-10 5:36 ` Alan Modra
2013-08-12 8:41 ` Tom Tromey
2013-08-12 9:29 ` Alan Modra
2013-08-14 11:25 ` nick clifton
2013-10-08 19:38 ` Tom Tromey
2013-10-08 22:10 ` Hans-Peter Nilsson
2013-10-09 1:27 ` Tom Tromey
2013-10-09 14:09 ` Tom Tromey [this message]
2013-10-09 14:54 ` Build regression on 32-bit hosts [Re: [PATCH] fix PR symtab/15597] Jan Kratochvil
2013-10-09 15:46 ` Tom Tromey
2013-10-10 0:17 ` [PATCH] fix PR symtab/15597 Doug Evans
2013-10-10 2:29 ` Tom Tromey
2013-10-10 19:04 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uy2edtz.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox