From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25271 invoked by alias); 10 Oct 2013 00:17:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25257 invoked by uid 89); 10 Oct 2013 00:17:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f201.google.com Received: from mail-ob0-f201.google.com (HELO mail-ob0-f201.google.com) (209.85.214.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 10 Oct 2013 00:17:08 +0000 Received: by mail-ob0-f201.google.com with SMTP id wp4so453333obc.2 for ; Wed, 09 Oct 2013 17:17:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=oM5PLsXekShwRZaHNzlp8SIHPkBkXqvxf7hus3bJq78=; b=kWbrA4TTIGCNra87LDwbnuC7w5KZXa53n+cO0SWLDC5WrP/50wF8tis+lAN1Lk09gH Sc62hJ8obyoeCW6ZWwnKxcHehvRJ6bJOCth5SSQdztv3wnzfGHg/GX4bHxhyZQ4ZtCex MHekVcVE9iisu6sxQCQTe/3HpU/nUbp7rSmpBedDiBI48AU3K33vTq7/ajaQYrEyyi5m zFfc1hhAL5BydAt6NepwbtCN9myrwnNqiNZT+gFh2Qetjmhn3wlqZV/4FC/Pi4sDtRpr 3gFv+rKYJ2Lvu0vg+YjehetP3HKmaxXubefUEHwOotFZVlhRitwB0CMLZE7GvoXCmGRB yoPA== X-Gm-Message-State: ALoCoQmAd6ut0DM4s/NhyqMmUw6gIk8nNEa1KepffO2imDEYDnX1g3blTQx51sTKuwZiR3eSftDUxfCcD2F1T9dyKbtEm0alQTgEzyGOoN+imm34OWls2oqf0aGysV2uoSMD/d5jVXoyck22qWgYzCSx/Sv2i6tIqdVPuJk+GhwbogU5WfgW1H3SyuDzBAeicBkLEjUMQEEHSueivR3FBOFEey+YT7zhRw== X-Received: by 10.182.109.200 with SMTP id hu8mr2846317obb.20.1381364226113; Wed, 09 Oct 2013 17:17:06 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id k47si73934yha.2.1969.12.31.16.00.00 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Wed, 09 Oct 2013 17:17:06 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 923645A411A; Wed, 9 Oct 2013 17:17:05 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21077.61952.984944.635448@ruffy.mtv.corp.google.com> Date: Thu, 10 Oct 2013 00:17:00 -0000 To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] fix PR symtab/15597 In-Reply-To: <87pprfft9c.fsf@fleche.redhat.com> References: <1375983426-19308-1-git-send-email-tromey@redhat.com> <87pprfft9c.fsf@fleche.redhat.com> X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00326.txt.bz2 Tom Tromey writes: > >>>>> "Tom" == Tom Tromey writes: > > Tom> This patch fixes gdb PR symtab/15597. > Tom> The bug is that the .gnu_debugaltlink section includes the build-id of > Tom> the alt file, but gdb does not use it. > > I'm checking in an updated version of this patch now. > The only change is to fix the patch for the objfile_name change in gdb. > I rebuilt and regtested this on x86-64 Fedora 18. > > Tom > > * bfd-in2.h: Rebuild. > * opncls.c (bfd_get_alt_debug_link_info): Add buildid_len > parameter. Change type of buildid_out. Update. > (get_alt_debug_link_info_shim): New function. > (bfd_follow_gnu_debuglink): Use it. > > * Makefile.in (SFILES): Add build-id.c. > (HFILES_NO_SRCDIR): Add build-id.h. > * build-id.c: New file, largely from elfread.c. Modified > most functions. > * build-id.h: New file. > * dwarf2read.c (dwarf2_get_dwz_file): Update for change to > bfd_get_alt_debug_link_info. Verify dwz file's build-id. > Search for dwz file using build-id. > * elfread.c (build_id_bfd_get, build_id_verify) > (build_id_to_debug_filename, find_separate_debug_file): Remove. > > * gdb.dwarf2/dwzbuildid.exp: New file. > * lib/dwarf.exp (Dwarf::_section): Add "flags" and "type" > parameters. > (Dwarf::_defer_output): Change "section" parameter to > "section_spec"; update. > (Dwarf::gnu_debugaltlink, Dwarf::_note, Dwarf::build_id): New > procs. So code was moved to a different file and edited in one step (instead of moving it, and then editing it in a separate pass)? [not that I mind per se, but I thought doing things that way was more than just "nice to have"]