Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org,    Eli Zaretskii <eliz@gnu.org>,
	   Mark Kettenis <mark.kettenis@xs4all.nl>,
	   aburgess@broadcom.com
Subject: Re: [PATCH] Always print call-clobbered registers in outer frames. (was: Re: [PATCH+DOC] Print registers not saved in the frame as "<not saved>", instead of "<optimized out>".)
Date: Thu, 19 Sep 2013 23:22:00 -0000	[thread overview]
Message-ID: <21051.34632.428407.241275@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <523B4D48.3050206@redhat.com>

Pedro Alves writes:
 > gdb/
 > 2013-09-18  Pedro Alves  <palves@redhat.com>
 > 
 > 	* findvar.c (value_of_register): Rename to ...
 > 	(value_of_register_helper): ... this.
 > 	(value_of_register): Reimplement.
 > 	* infcmd.c (default_print_one_register_info): Use
 > 	value_of_register instead of get_frame_register_value.
 > 	* mi/mi-main.c (output_register): Use value_of_register instead of
 > 	get_frame_register_value.
 > 
 > gdb/testsuite/
 > 2013-09-18  Pedro Alves  <palves@redhat.com>
 > 
 > 	* gdb.dwarf2/dw2-reg-undefined.exp: Expect hex numbers instead of
 > 	"<optimized out>" for all frames.
 > 	* gdb.mi/mi-reg-undefined.exp (opt_out_pattern): Delete.
 > 	(top level): Expect hex numbers instead of "<optimized out>" for
 > 	all frames.
 > 
 > gdb/doc/
 > 2013-09-18  Pedro Alves  <palves@redhat.com>
 > 
 > 	* gdb.texinfo (Registers): Expand explanation of not-saved
 > 	call-clobbered registers in frames other than the innermost.

Sorry for the followup.
This doesn't have to be part of this patch of course, but IWBN if "i reg"
included a note next to register values obtained via heuristics.
[such values could have a flag set]

It could even be just a general warning printed by "i reg" in
non-inner-most frames, but it feels like the above shouldn't be too hard.


  parent reply	other threads:[~2013-09-19 23:22 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06 13:09 [PATCH] Consistent display of "<optimized out>" Andrew Burgess
2013-08-06 13:18 ` Mark Kettenis
2013-08-06 13:49   ` Andrew Burgess
2013-08-06 15:41     ` Mark Kettenis
2013-08-06 16:02       ` Andrew Burgess
2013-08-06 18:39       ` Pedro Alves
2013-08-12 13:32         ` Andrew Burgess
2013-08-12 13:55           ` Pedro Alves
2013-08-12 14:01             ` Andrew Burgess
2013-08-12 20:01             ` Mark Kettenis
2013-08-13  8:27               ` Andrew Burgess
2013-08-16 18:41               ` Pedro Alves
2013-08-16 20:28                 ` Pedro Alves
2013-08-19 10:25                 ` Andrew Burgess
2013-09-05 16:29                   ` [PATCH] Print registers not saved in the frame as "<not saved>", instead of "<optimized out>". (was: Re: [PATCH] Consistent display of "<optimized out>") Pedro Alves
2013-09-05 16:35                     ` [PATCH] Print registers not saved in the frame as "<not saved>", instead of "<optimized out>" Andrew Burgess
2013-09-16 19:05                       ` Pedro Alves
2013-09-18 14:04                         ` Andrew Burgess
2013-09-18 15:54                           ` [PATCH+DOC] " Pedro Alves
2013-09-18 16:30                             ` Eli Zaretskii
2013-09-18 17:35                               ` Pedro Alves
2013-09-18 19:35                                 ` Eli Zaretskii
2013-09-18 20:47                               ` Mark Kettenis
2013-09-19  7:53                                 ` Eli Zaretskii
2013-09-19 16:58                                   ` Pedro Alves
2013-09-19 19:15                                     ` [PATCH] Always print call-clobbered registers in outer frames. (was: Re: [PATCH+DOC] Print registers not saved in the frame as "<not saved>", instead of "<optimized out>".) Pedro Alves
2013-09-19 19:35                                       ` Eli Zaretskii
2013-09-19 23:13                                       ` Doug Evans
2013-09-19 23:22                                       ` Doug Evans [this message]
2013-09-20 11:04                                       ` [PATCH] Always print call-clobbered registers in outer frames Andrew Burgess
2013-09-24 12:07                                         ` Pedro Alves
2013-09-24 12:56                                           ` Andrew Burgess
2013-09-24 13:43                                             ` Pedro Alves
2013-09-24 15:18                                               ` Andrew Burgess
2013-09-24 19:36                                                 ` Pedro Alves
2013-09-24 23:22                                                   ` Andrew Burgess
2013-10-02 16:05                                                     ` Pedro Alves
2013-10-02 19:07                                                       ` Doug Evans
2013-09-20 12:28                                       ` [PATCH] Always print call-clobbered registers in outer frames. (was: Re: [PATCH+DOC] Print registers not saved in the frame as "<not saved>", instead of "<optimized out>".) Mark Kettenis
2013-09-24 12:06                                         ` [PATCH] Always print call-clobbered registers in outer frames Pedro Alves
2013-10-02 16:17                                     ` [PATCH+DOC] Print registers not saved in the frame as "<not saved>", instead of "<optimized out>" Pedro Alves
2013-09-18 16:30                             ` Andreas Schwab
2013-09-18 17:36                               ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21051.34632.428407.241275@ruffy.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=aburgess@broadcom.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox