* [pushed] gdb/aarch64: fix indentation in aarch64-tdep.c
@ 2026-10-19 14:49 Simon Marchi
0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2026-10-19 14:49 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
I noticed a misleading indentation clang-tidy warning while editing
aarch64-tdep.c in my editor. Fix it, and add some missing braces, which
our coding style requires for nested ifs.
Change-Id: Ieca14863995b3455abc0a2cdd3010102d67d5a1e
---
gdb/aarch64-tdep.c | 53 ++++++++++++++++++++++++++--------------------
1 file changed, 30 insertions(+), 23 deletions(-)
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 10b74ff1438c..109fca6bf110 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -6179,20 +6179,24 @@ aarch64_record_load_store (aarch64_insn_decode_record *aarch64_insn_r)
debug_printf ("Process record: load/store (register offset)\n");
opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
if (!(opc >> 1))
- if (opc & 0x01)
- ld_flag = 0x01;
- else
- ld_flag = 0x0;
+ {
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ }
else
- if (size_bits != 0x03)
- ld_flag = 0x01;
- else if (size_bits == 0x3 && vector_flag == 0x0 && opc == 0x2)
- {
- /* PRFM (register) or RPRFM */
- return AARCH64_RECORD_SUCCESS;
- }
- else
- return AARCH64_RECORD_UNKNOWN;
+ {
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else if (size_bits == 0x3 && vector_flag == 0x0 && opc == 0x2)
+ {
+ /* PRFM (register) or RPRFM */
+ return AARCH64_RECORD_SUCCESS;
+ }
+ else
+ return AARCH64_RECORD_UNKNOWN;
+ }
if (!ld_flag)
{
@@ -6232,19 +6236,22 @@ aarch64_record_load_store (aarch64_insn_decode_record *aarch64_insn_r)
}
opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
if (!(opc >> 1))
- if (opc & 0x01)
- ld_flag = 0x01;
- else
- ld_flag = 0x0;
+ {
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ }
else
- if (size_bits != 0x03)
- ld_flag = 0x01;
- else
- if (insn_bits10_11 == 0)
+ {
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else if (insn_bits10_11 == 0)
/* PRFUM instruction. */
return AARCH64_RECORD_SUCCESS;
- else
- return AARCH64_RECORD_UNKNOWN;
+ else
+ return AARCH64_RECORD_UNKNOWN;
+ }
if (!ld_flag)
{
base-commit: 21cf31310977a3a70074ace8d968d17480909656
--
2.56.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-19 14:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-19 14:49 [pushed] gdb/aarch64: fix indentation in aarch64-tdep.c Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox