From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9XuHJSEu1mrbfzIAWB0awg (envelope-from ) for ; Mon, 19 Oct 2026 10:50:09 -0400 Received: by simark.ca (Postfix, from userid 112) id 87D391E04E; Mon, 19 Oct 2026 10:50:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AFA6F1E04E for ; Mon, 19 Oct 2026 10:50:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1E8604BA23DE for ; Mon, 19 Oct 2026 14:50:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E8604BA23DE Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 61F9F4BA2E2E for ; Mon, 19 Oct 2026 14:49:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 61F9F4BA2E2E Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 61F9F4BA2E2E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792421384; cv=none; b=eaUOiSFJmjgFEdAwfxIzJgbjUIZio29LHpsgaNu1g/4F5H/S+/wtDnajsTBxqvLF5msv+se5grts6KXQI3QZjVyhyq6G31oZO0Fle7jha5qWic/61FLM+JQD73mpcrUvcDTDq6ZP5jTHUKaKnGurx4d1YjRKCWDsKmZsItsDK8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792421384; c=relaxed/simple; bh=7Njs3oWWTLQd1I83qrFXcPQ8LEfVI0mi87Qwb/2FqR8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=AldaB8a5I7UoZlD6hR3iyXXc6a/cu3KnCcU3rYqrdBKNAB2FaK6SOZF0Ok3+eEWIwwQEWKv+1bHREi1EUBlLfvk5E4YIXkemr+NrsHVclmkDOTHxiM5O+FOv2Z7TcV6UKO8wFLIo5bye33xQdCRcoPVwWV+JiL+1bKpjllB2+Zo= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 61F9F4BA2E2E Received: by simark.ca (Postfix) id D9AD51E04E; Mon, 19 Oct 2026 10:49:43 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdb/aarch64: fix indentation in aarch64-tdep.c Date: Mon, 19 Oct 2026 10:49:41 -0400 Message-ID: <20261019144942.274815-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed a misleading indentation clang-tidy warning while editing aarch64-tdep.c in my editor. Fix it, and add some missing braces, which our coding style requires for nested ifs. Change-Id: Ieca14863995b3455abc0a2cdd3010102d67d5a1e --- gdb/aarch64-tdep.c | 53 ++++++++++++++++++++++++++-------------------- 1 file changed, 30 insertions(+), 23 deletions(-) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 10b74ff1438c..109fca6bf110 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -6179,20 +6179,24 @@ aarch64_record_load_store (aarch64_insn_decode_record *aarch64_insn_r) debug_printf ("Process record: load/store (register offset)\n"); opc = bits (aarch64_insn_r->aarch64_insn, 22, 23); if (!(opc >> 1)) - if (opc & 0x01) - ld_flag = 0x01; - else - ld_flag = 0x0; + { + if (opc & 0x01) + ld_flag = 0x01; + else + ld_flag = 0x0; + } else - if (size_bits != 0x03) - ld_flag = 0x01; - else if (size_bits == 0x3 && vector_flag == 0x0 && opc == 0x2) - { - /* PRFM (register) or RPRFM */ - return AARCH64_RECORD_SUCCESS; - } - else - return AARCH64_RECORD_UNKNOWN; + { + if (size_bits != 0x03) + ld_flag = 0x01; + else if (size_bits == 0x3 && vector_flag == 0x0 && opc == 0x2) + { + /* PRFM (register) or RPRFM */ + return AARCH64_RECORD_SUCCESS; + } + else + return AARCH64_RECORD_UNKNOWN; + } if (!ld_flag) { @@ -6232,19 +6236,22 @@ aarch64_record_load_store (aarch64_insn_decode_record *aarch64_insn_r) } opc = bits (aarch64_insn_r->aarch64_insn, 22, 23); if (!(opc >> 1)) - if (opc & 0x01) - ld_flag = 0x01; - else - ld_flag = 0x0; + { + if (opc & 0x01) + ld_flag = 0x01; + else + ld_flag = 0x0; + } else - if (size_bits != 0x03) - ld_flag = 0x01; - else - if (insn_bits10_11 == 0) + { + if (size_bits != 0x03) + ld_flag = 0x01; + else if (insn_bits10_11 == 0) /* PRFUM instruction. */ return AARCH64_RECORD_SUCCESS; - else - return AARCH64_RECORD_UNKNOWN; + else + return AARCH64_RECORD_UNKNOWN; + } if (!ld_flag) { base-commit: 21cf31310977a3a70074ace8d968d17480909656 -- 2.56.0