Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [pushed] gdb/testsuite: adapt gdb.rocm/symbol-lookup.exp to amdclang++
@ 2026-09-06  3:32 simon.marchi
  0 siblings, 0 replies; only message in thread
From: simon.marchi @ 2026-09-06  3:32 UTC (permalink / raw)
  To: gdb-patches; +Cc: Simon Marchi

From: Simon Marchi <simon.marchi@polymtl.ca>

When pushing commit 822c4cd732ce ("gdb: multiple solib_ops per program
space"), I failed to adapt the code to the changes introduced by commit
382e5c4d32f6 ("gdb/testsuite: replace hipcc with amdclang++ as the HIP
compiler"), causing:

    invalid command name "allow_hipcc_tests"

This patches fixes two issues:

 - allow_hipcc_tests -> allow_hip_tests
 - --genco -> --cuda-device-only

This mirrors what was done by commit 382e5c4d32f6 in file
gdb.rocm/code-object-load-while-breakpoint-hit.exp, which builds a
standalone device code object in the same way.

With this, the test passes here (76 PASSes) instead of erroring out.

Change-Id: I5dca6cceb0ea48041b35f53f78338019b08a0e6d
---
 gdb/testsuite/gdb.rocm/symbol-lookup.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.rocm/symbol-lookup.exp b/gdb/testsuite/gdb.rocm/symbol-lookup.exp
index ce74e74177a5..6cae7dbfe5b4 100644
--- a/gdb/testsuite/gdb.rocm/symbol-lookup.exp
+++ b/gdb/testsuite/gdb.rocm/symbol-lookup.exp
@@ -48,7 +48,7 @@ load_lib rocm.exp
 
 standard_testfile .cpp
 
-require allow_hipcc_tests
+require allow_hip_tests
 
 # Build the main program.
 if { [build_executable "failed to prepare" \
@@ -79,7 +79,7 @@ foreach n {1 2} {
 
     # Build the ROCm code object N
     if { [gdb_compile $srcdir/$subdir/$srcfile $code_object object \
-	  [list debug hip additional_flags=--genco additional_flags=-DCODE_OBJECT_$n]] != "" } {
+	  [list debug hip additional_flags=--cuda-device-only additional_flags=-DCODE_OBJECT_$n]] != "" } {
 	return
     }
 }

base-commit: 0f6f5333711f8b34f71276c3368f21baebf52c41
-- 
2.55.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-06  3:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-06  3:32 [pushed] gdb/testsuite: adapt gdb.rocm/symbol-lookup.exp to amdclang++ simon.marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox