From: simon.marchi@polymtl.ca
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [pushed] gdb/testsuite: adapt gdb.rocm/symbol-lookup.exp to amdclang++
Date: Sat, 5 Sep 2026 23:32:29 -0400 [thread overview]
Message-ID: <20260906033231.3548729-1-simon.marchi@polymtl.ca> (raw)
From: Simon Marchi <simon.marchi@polymtl.ca>
When pushing commit 822c4cd732ce ("gdb: multiple solib_ops per program
space"), I failed to adapt the code to the changes introduced by commit
382e5c4d32f6 ("gdb/testsuite: replace hipcc with amdclang++ as the HIP
compiler"), causing:
invalid command name "allow_hipcc_tests"
This patches fixes two issues:
- allow_hipcc_tests -> allow_hip_tests
- --genco -> --cuda-device-only
This mirrors what was done by commit 382e5c4d32f6 in file
gdb.rocm/code-object-load-while-breakpoint-hit.exp, which builds a
standalone device code object in the same way.
With this, the test passes here (76 PASSes) instead of erroring out.
Change-Id: I5dca6cceb0ea48041b35f53f78338019b08a0e6d
---
gdb/testsuite/gdb.rocm/symbol-lookup.exp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.rocm/symbol-lookup.exp b/gdb/testsuite/gdb.rocm/symbol-lookup.exp
index ce74e74177a5..6cae7dbfe5b4 100644
--- a/gdb/testsuite/gdb.rocm/symbol-lookup.exp
+++ b/gdb/testsuite/gdb.rocm/symbol-lookup.exp
@@ -48,7 +48,7 @@ load_lib rocm.exp
standard_testfile .cpp
-require allow_hipcc_tests
+require allow_hip_tests
# Build the main program.
if { [build_executable "failed to prepare" \
@@ -79,7 +79,7 @@ foreach n {1 2} {
# Build the ROCm code object N
if { [gdb_compile $srcdir/$subdir/$srcfile $code_object object \
- [list debug hip additional_flags=--genco additional_flags=-DCODE_OBJECT_$n]] != "" } {
+ [list debug hip additional_flags=--cuda-device-only additional_flags=-DCODE_OBJECT_$n]] != "" } {
return
}
}
base-commit: 0f6f5333711f8b34f71276c3368f21baebf52c41
--
2.55.0
reply other threads:[~2026-09-06 3:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906033231.3548729-1-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox