Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] [gdb/testsuite] gdb.rocm/step-abort.exp: prevent ROCr core dumps on exceptions
@ 2026-08-17 17:09 Luis Machado
  2026-08-17 17:27 ` Six, Lancelot
  0 siblings, 1 reply; 2+ messages in thread
From: Luis Machado @ 2026-08-17 17:09 UTC (permalink / raw)
  To: gdb-patches, Lancelot.Six

Do not let the runtime generate core dumps. It slows things down and it does
not get used in the test.

---
 gdb/testsuite/gdb.rocm/step-abort.exp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/testsuite/gdb.rocm/step-abort.exp b/gdb/testsuite/gdb.rocm/step-abort.exp
index f13ccfcd159..a4cd000260c 100644
--- a/gdb/testsuite/gdb.rocm/step-abort.exp
+++ b/gdb/testsuite/gdb.rocm/step-abort.exp
@@ -33,6 +33,8 @@ proc do_test {} {
     clean_restart $::testfile
 
     with_rocm_gpu_lock {
+	# Prevent ROCr from generating a GPU core dump.
+	gdb_test_no_output "set environment HSA_DISABLE_COREDUMP_ON_EXCEPTION=1"
 	if {![runto_main]} {
 	    return
 	}
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] [gdb/testsuite] gdb.rocm/step-abort.exp: prevent ROCr core dumps on exceptions
  2026-08-17 17:09 [PATCH] [gdb/testsuite] gdb.rocm/step-abort.exp: prevent ROCr core dumps on exceptions Luis Machado
@ 2026-08-17 17:27 ` Six, Lancelot
  0 siblings, 0 replies; 2+ messages in thread
From: Six, Lancelot @ 2026-08-17 17:27 UTC (permalink / raw)
  To: Machado, Luis, gdb-patches

AMD General

> -----Original Message-----
> From: Machado, Luis <Luis.Machado@amd.com>
> Sent: 17 August 2026 18:10
> To: gdb-patches@sourceware.org; Six, Lancelot <Lancelot.Six@amd.com>
> Subject: [PATCH] [gdb/testsuite] gdb.rocm/step-abort.exp: prevent ROCr core
> dumps on exceptions
>
> Do not let the runtime generate core dumps. It slows things down and it does
> not get used in the test.

Hi,

Thanks, this looks good to me.

Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)

Best,
Lancelot.

>
> ---
>  gdb/testsuite/gdb.rocm/step-abort.exp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.rocm/step-abort.exp
> b/gdb/testsuite/gdb.rocm/step-abort.exp
> index f13ccfcd159..a4cd000260c 100644
> --- a/gdb/testsuite/gdb.rocm/step-abort.exp
> +++ b/gdb/testsuite/gdb.rocm/step-abort.exp
> @@ -33,6 +33,8 @@ proc do_test {} {
>      clean_restart $::testfile
>
>      with_rocm_gpu_lock {
> +     # Prevent ROCr from generating a GPU core dump.
> +     gdb_test_no_output "set environment
> HSA_DISABLE_COREDUMP_ON_EXCEPTION=1"
>       if {![runto_main]} {
>           return
>       }
> --
> 2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-17 17:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-17 17:09 [PATCH] [gdb/testsuite] gdb.rocm/step-abort.exp: prevent ROCr core dumps on exceptions Luis Machado
2026-08-17 17:27 ` Six, Lancelot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox