RE: [PATCH] [gdb/testsuite] gdb.rocm/step-abort.exp: prevent ROCr core dumps on exceptions

["Six, Lancelot" <Lancelot.Six@amd.com>]

AMD General

> -----Original Message-----
> From: Machado, Luis <Luis.Machado@amd.com>
> Sent: 17 August 2026 18:10
> To: gdb-patches@sourceware.org; Six, Lancelot <Lancelot.Six@amd.com>
> Subject: [PATCH] [gdb/testsuite] gdb.rocm/step-abort.exp: prevent ROCr core
> dumps on exceptions
>
> Do not let the runtime generate core dumps. It slows things down and it does
> not get used in the test.

Hi,

Thanks, this looks good to me.

Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)

Best,
Lancelot.

>
> ---
>  gdb/testsuite/gdb.rocm/step-abort.exp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.rocm/step-abort.exp
> b/gdb/testsuite/gdb.rocm/step-abort.exp
> index f13ccfcd159..a4cd000260c 100644
> --- a/gdb/testsuite/gdb.rocm/step-abort.exp
> +++ b/gdb/testsuite/gdb.rocm/step-abort.exp
> @@ -33,6 +33,8 @@ proc do_test {} {
>      clean_restart $::testfile
>
>      with_rocm_gpu_lock {
> +     # Prevent ROCr from generating a GPU core dump.
> +     gdb_test_no_output "set environment
> HSA_DISABLE_COREDUMP_ON_EXCEPTION=1"
>       if {![runto_main]} {
>           return
>       }
> --
> 2.43.0