Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH v2] Minor 'debug_*' function improvements
@ 2026-08-06 20:30 Tom Tromey
  2026-08-07  6:56 ` Tom de Vries
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2026-08-06 20:30 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

I wanted to get a summary of a type in gdb and then realized I had
forgotten the function name, so I had to dig around to find it.  This
made me think that perhaps renaming the debug_* functions to all just
be named 'debug' would be an improvement, since it's easier to
remember.

Then I noticed that debug_type and debug_val don't print a trailing
newline.

Finally, I needed to be able to see the contents of a gdb_mpz.

v2 changes these functions to use ATTRIBUTE_USED rather than
ATTRIBUTE_UNUSED, as the former indicates that these should not be
deleted even if apparently unused.
---
 gdb/expprint.c  |  4 ++--
 gdb/gmp-utils.c | 12 ++++++++++++
 gdb/typeprint.c |  7 ++++---
 gdb/valprint.c  |  7 ++++---
 4 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/gdb/expprint.c b/gdb/expprint.c
index bc1929b1a1b..4859d48f6a4 100644
--- a/gdb/expprint.c
+++ b/gdb/expprint.c
@@ -35,13 +35,13 @@
 
 
 /* Meant to be used in debug sessions, so don't export it in a header file.  */
-extern void ATTRIBUTE_USED debug_exp (struct expression *exp);
+extern void ATTRIBUTE_USED debug (struct expression *exp);
 
 /* Print EXP.  */
 
 void
 ATTRIBUTE_USED
-debug_exp (struct expression *exp)
+debug (struct expression *exp)
 {
   exp->dump (gdb_stdlog);
   gdb_flush (gdb_stdlog);
diff --git a/gdb/gmp-utils.c b/gdb/gmp-utils.c
index 168479c50df..b7fed9a82d1 100644
--- a/gdb/gmp-utils.c
+++ b/gdb/gmp-utils.c
@@ -39,6 +39,18 @@ gmp_string_printf (const char *fmt, ...)
   return str;
 }
 
+/* Meant to be used in debug sessions, so don't export it in a header file.  */
+extern void ATTRIBUTE_USED debug (const gdb_mpz &);
+
+/* Print VAL.  */
+
+void ATTRIBUTE_USED
+debug (const gdb_mpz &val)
+{
+  gdb_printf (gdb_stdlog, "%s\n", val.str ().c_str ());
+  gdb_flush (gdb_stdlog);
+}
+
 /* See gmp-utils.h.  */
 
 void
diff --git a/gdb/typeprint.c b/gdb/typeprint.c
index 31a9c1814a3..7d1ebc6fdca 100644
--- a/gdb/typeprint.c
+++ b/gdb/typeprint.c
@@ -516,14 +516,15 @@ ptype_command (const char *type_name, int from_tty)
 }
 
 /* Meant to be used in debug sessions, so don't export it in a header file.  */
-extern void ATTRIBUTE_UNUSED debug_type (struct type *type);
+extern void ATTRIBUTE_USED debug (struct type *type);
 
 /* Print TYPE.  */
 
-void ATTRIBUTE_UNUSED
-debug_type (struct type *type)
+void ATTRIBUTE_USED
+debug (struct type *type)
 {
   type_print (type, "", gdb_stdlog, 1);
+  gdb_printf (gdb_stdlog, "\n");
   gdb_flush (gdb_stdlog);
 }
 
diff --git a/gdb/valprint.c b/gdb/valprint.c
index 50a4663ca3b..3e7a37338b3 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -1232,14 +1232,15 @@ value_print (struct value *val, struct ui_file *stream,
 }
 
 /* Meant to be used in debug sessions, so don't export it in a header file.  */
-extern void ATTRIBUTE_UNUSED debug_val (struct value *val);
+extern void ATTRIBUTE_USED debug (struct value *val);
 
 /* Print VAL.  */
 
-void ATTRIBUTE_UNUSED
-debug_val (struct value *val)
+void ATTRIBUTE_USED
+debug (struct value *val)
 {
   value_print (val, gdb_stdlog, &user_print_options);
+  gdb_printf (gdb_stdlog, "\n");
   gdb_flush (gdb_stdlog);
 }
 

base-commit: 035b2e70824ab51ec4d6754345456622c618b450
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-07  6:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-06 20:30 [PATCH v2] Minor 'debug_*' function improvements Tom Tromey
2026-08-07  6:56 ` Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox