From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ecL/Fd2BdWoR3w8AWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 02:57:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zbQ+10it; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=P/MmZ/cs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=E+WD5kFR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GyhiX5bk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4EDC61E166; Fri, 07 Aug 2026 02:57:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A4D371E033 for ; Fri, 07 Aug 2026 02:57:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 85C5F4BAE7CC for ; Fri, 7 Aug 2026 06:57:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85C5F4BAE7CC Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zbQ+10it; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=P/MmZ/cs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=E+WD5kFR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GyhiX5bk Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 82A974BA900F for ; Fri, 7 Aug 2026 06:56:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82A974BA900F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 82A974BA900F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786085814; cv=none; b=h1ff7rCYcNkcB0QNYjxuoUipKsSvaT6bJe/fP95m/RT09/m+bAC0P4uuCCqcE4Xz2WCO7sY+NWF8rKWR043tPX4ReETy4NmzMcqfMRJUCt1wVwccgCmPxZLYvJdon9xQQkvoqdWswDskI7bFlDoL2QI7RGr6msGPQ/eHGGSOamw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786085814; c=relaxed/simple; bh=mPB7rnBk8KxyQcsyTrz1SrJsFafSAgutk4a8FP/zukc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=J0gkL8vO472o0Nkywgh6uqpSAwLHjwzPehDRWMi/2qeHm/laHhYurWLLynQh7KETl+l3CaZXPHaxhUVSBkpiPsikd7u+lLQGtLfzRfc1/W5uGZcMzwb2YdefJc+7B3K6rcPUFfJ/W9bOzg9Y8EbBcQevDGi/2S1G/fqerT+tUQU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zbQ+10it; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=P/MmZ/cs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=E+WD5kFR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GyhiX5bk DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82A974BA900F Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 105CB3DFF; Fri, 7 Aug 2026 06:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786085809; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRb86ZNIE1a5yrAKqgQPMtgBPto/3DJAdb5Z4xcsE60=; b=zbQ+10itxRTa10o7mrvbsYB0MWmTe+9YcJdJUW1p5oDra5W4yr6iztvttiYV8g+vL8opYH pYxiqLM/hKKIx9FeMFL6iOW4dtEcHZZn/HoLe/5pVo2nwvKsH2Afv33GkqDS4m2gVCm5tn 1r2dl+XDJ34ji/XBsNL9onUM/UVL3Ro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786085809; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRb86ZNIE1a5yrAKqgQPMtgBPto/3DJAdb5Z4xcsE60=; b=P/MmZ/csZYQg7mtpDYMLaPwvI22kYLbkXsEMSbouwXc6vvpHec0lPeB7dYpFbwtZNfp+xM MtexUnQjWJx+7bCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786085805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRb86ZNIE1a5yrAKqgQPMtgBPto/3DJAdb5Z4xcsE60=; b=E+WD5kFRwL6InnF+gS5hDvG66w1bWhAAX/vq0YDSsh2RYj2z+KdO3ykYHZbGkVqnaMn/o9 Hpa2f5bFwPmqgkYT6VgHV9ByeAD4pzCiMszxN8c1hYhlU1oPwIIiiwXnJt2cFBqFS4ajpZ Bcwqs3ZyQDjBPn5/29hf7O/IweGaZRk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786085805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRb86ZNIE1a5yrAKqgQPMtgBPto/3DJAdb5Z4xcsE60=; b=GyhiX5bkr1+P58Xxst+JJwcmo4OlFmcgIwGclyRnlaiLnyi9vhN9eCW9grmsdmtS5EkmXN LiXRwMtQTiI8i3AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EFE6A779B6; Fri, 7 Aug 2026 06:56:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QJxIOayBdWrRcQAAD6G6ig (envelope-from ); Fri, 07 Aug 2026 06:56:44 +0000 Message-ID: <271db128-b510-4d26-9567-3c0eff498f24@suse.de> Date: Fri, 7 Aug 2026 08:56:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Minor 'debug_*' function improvements To: Tom Tromey , gdb-patches@sourceware.org References: <20260806203039.1140017-1-tromey@adacore.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260806203039.1140017-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.19)[-0.965]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/6/26 10:30 PM, Tom Tromey wrote: > I wanted to get a summary of a type in gdb and then realized I had > forgotten the function name, so I had to dig around to find it. This > made me think that perhaps renaming the debug_* functions to all just > be named 'debug' would be an improvement, since it's easier to > remember. > > Then I noticed that debug_type and debug_val don't print a trailing > newline. > > Finally, I needed to be able to see the contents of a gdb_mpz. > > v2 changes these functions to use ATTRIBUTE_USED rather than > ATTRIBUTE_UNUSED, as the former indicates that these should not be > deleted even if apparently unused. Hi Tom, thanks for doing this. No further comments. Approved-By: Tom de Vries Thanks, - Tom > --- > gdb/expprint.c | 4 ++-- > gdb/gmp-utils.c | 12 ++++++++++++ > gdb/typeprint.c | 7 ++++--- > gdb/valprint.c | 7 ++++--- > 4 files changed, 22 insertions(+), 8 deletions(-) > > diff --git a/gdb/expprint.c b/gdb/expprint.c > index bc1929b1a1b..4859d48f6a4 100644 > --- a/gdb/expprint.c > +++ b/gdb/expprint.c > @@ -35,13 +35,13 @@ > > > /* Meant to be used in debug sessions, so don't export it in a header file. */ > -extern void ATTRIBUTE_USED debug_exp (struct expression *exp); > +extern void ATTRIBUTE_USED debug (struct expression *exp); > > /* Print EXP. */ > > void > ATTRIBUTE_USED > -debug_exp (struct expression *exp) > +debug (struct expression *exp) > { > exp->dump (gdb_stdlog); > gdb_flush (gdb_stdlog); > diff --git a/gdb/gmp-utils.c b/gdb/gmp-utils.c > index 168479c50df..b7fed9a82d1 100644 > --- a/gdb/gmp-utils.c > +++ b/gdb/gmp-utils.c > @@ -39,6 +39,18 @@ gmp_string_printf (const char *fmt, ...) > return str; > } > > +/* Meant to be used in debug sessions, so don't export it in a header file. */ > +extern void ATTRIBUTE_USED debug (const gdb_mpz &); > + > +/* Print VAL. */ > + > +void ATTRIBUTE_USED > +debug (const gdb_mpz &val) > +{ > + gdb_printf (gdb_stdlog, "%s\n", val.str ().c_str ()); > + gdb_flush (gdb_stdlog); > +} > + > /* See gmp-utils.h. */ > > void > diff --git a/gdb/typeprint.c b/gdb/typeprint.c > index 31a9c1814a3..7d1ebc6fdca 100644 > --- a/gdb/typeprint.c > +++ b/gdb/typeprint.c > @@ -516,14 +516,15 @@ ptype_command (const char *type_name, int from_tty) > } > > /* Meant to be used in debug sessions, so don't export it in a header file. */ > -extern void ATTRIBUTE_UNUSED debug_type (struct type *type); > +extern void ATTRIBUTE_USED debug (struct type *type); > > /* Print TYPE. */ > > -void ATTRIBUTE_UNUSED > -debug_type (struct type *type) > +void ATTRIBUTE_USED > +debug (struct type *type) > { > type_print (type, "", gdb_stdlog, 1); > + gdb_printf (gdb_stdlog, "\n"); > gdb_flush (gdb_stdlog); > } > > diff --git a/gdb/valprint.c b/gdb/valprint.c > index 50a4663ca3b..3e7a37338b3 100644 > --- a/gdb/valprint.c > +++ b/gdb/valprint.c > @@ -1232,14 +1232,15 @@ value_print (struct value *val, struct ui_file *stream, > } > > /* Meant to be used in debug sessions, so don't export it in a header file. */ > -extern void ATTRIBUTE_UNUSED debug_val (struct value *val); > +extern void ATTRIBUTE_USED debug (struct value *val); > > /* Print VAL. */ > > -void ATTRIBUTE_UNUSED > -debug_val (struct value *val) > +void ATTRIBUTE_USED > +debug (struct value *val) > { > value_print (val, gdb_stdlog, &user_print_options); > + gdb_printf (gdb_stdlog, "\n"); > gdb_flush (gdb_stdlog); > } > > > base-commit: 035b2e70824ab51ec4d6754345456622c618b450