From: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <tom@tromey.com>
Subject: [PATCH v2 13/17] gdb: convert TYPE_DATA_SPACE macro to type::is_data_space
Date: Wed, 22 Jul 2026 05:42:02 -0500 [thread overview]
Message-ID: <20260722-users-aktemur-type-instance-flags-v2-13-d60dcbc2a76f@amd.com> (raw)
In-Reply-To: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com>
Convert the TYPE_DATA_SPACE macro to a method of the type class. This
is a refactoring.
---
gdb/avr-tdep.c | 2 +-
gdb/c-typeprint.c | 2 +-
gdb/gdbtypes.c | 6 ++----
gdb/gdbtypes.h | 9 ++++++---
4 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c
index 26b786c68b7..682b7e8586d 100644
--- a/gdb/avr-tdep.c
+++ b/gdb/avr-tdep.c
@@ -361,7 +361,7 @@ avr_integer_to_address (struct gdbarch *gdbarch,
{
ULONGEST addr = unpack_long (type, buf);
- if (TYPE_DATA_SPACE (type))
+ if (type->is_data_space ())
return avr_make_saddr (addr);
else
return avr_make_iaddr (addr);
diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c
index a8927e0ac43..d26640e10e6 100644
--- a/gdb/c-typeprint.c
+++ b/gdb/c-typeprint.c
@@ -487,7 +487,7 @@ c_type_print_modifier (struct type *type, struct ui_file *stream,
if (type->is_code_space ())
address_space_id = "code";
- else if (TYPE_DATA_SPACE (type))
+ else if (type->is_data_space ())
address_space_id = "data";
else if (gdbarch_address_class_id_to_name_p (type->arch ()))
address_space_id
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 465af4790fd..731c7436dc6 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -5027,10 +5027,8 @@ recursive_dump_type (struct type *type, int spaces)
gdb_puts (" TYPE_VOLATILE");
if (type->is_code_space ())
gdb_puts (" TYPE_CODE_SPACE");
- if (TYPE_DATA_SPACE (type))
- {
- gdb_puts (" TYPE_DATA_SPACE");
- }
+ if (type->is_data_space ())
+ gdb_puts (" TYPE_DATA_SPACE");
if (TYPE_ADDRESS_CLASS (type) != 0)
{
gdb_printf (" TYPE_ADDRESS_CLASS(%u)", TYPE_ADDRESS_CLASS (type));
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index d9988312e1b..b6c3b219419 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -189,9 +189,6 @@ struct type_instance_flags
(((t)->dyn_prop (DYN_PROP_BYTE_SIZE) != nullptr) \
|| ((t)->dyn_prop (DYN_PROP_BIT_SIZE) != nullptr))
-#define TYPE_DATA_SPACE(t) \
- (((t)->instance_flags ()).harvard_aspace == HARVARD_ASPACE_DATA)
-
#define TYPE_ADDRESS_CLASS(t) \
(((t)->instance_flags ()).address_class)
@@ -1219,6 +1216,12 @@ struct type
return this->m_instance_flags.harvard_aspace == HARVARD_ASPACE_CODE;
}
+ /* Return if this type is in the data space. */
+ bool is_data_space () const
+ {
+ return this->m_instance_flags.harvard_aspace == HARVARD_ASPACE_DATA;
+ }
+
/* Get the bounds bounds of this type. The type must be a range type. */
range_bounds *bounds () const
{
--
2.34.1
next prev parent reply other threads:[~2026-07-22 10:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 10:41 [PATCH v2 00/17] Rewrite type instance flags as a struct with bitfields Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 01/17] gdb: use type instance macros to query const, volatile, restrict Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 02/17] gdb: convert address_class_type_flags_to_name to address_class_id_to_name Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 03/17] gdb: convert address_class_name_to_type_flags to address_class_name_to_id Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 04/17] gdb: convert address_class_type_flags to address_class_dwarf_to_id Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 05/17] gdb: refactor type_stack::insert methods Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 06/17] gdb: inline address_space_{name, type_instance_flags}_to_{type_instance_flags, name} Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 07/17] gdb: split make_type_with_address_space Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 08/17] gdb: convert type instance flags to bitfields Tankut Baris Aktemur
2026-07-24 19:10 ` Keith Seitz
2026-07-22 10:41 ` [PATCH v2 09/17] gdb: convert TYPE_NOTTEXT macro to type::is_nottext Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 10/17] gdb: convert TYPE_CONST macro to type::is_const Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 11/17] gdb: convert TYPE_VOLATILE macro to type::is_volatile Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 12/17] gdb: convert TYPE_CODE_SPACE macro to type::is_code_space Tankut Baris Aktemur
2026-07-22 10:42 ` Tankut Baris Aktemur [this message]
2026-07-22 10:42 ` [PATCH v2 14/17] gdb: convert TYPE_RESTRICT macro to type::is_restrict Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 15/17] gdb: convert TYPE_ATOMIC macro to type::is_atomic Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 16/17] gdb: convert TYPE_ADDRESS_CLASS macro to type::address_class Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 17/17] gdb: remove unnecessary braces in recursive_dump_type Tankut Baris Aktemur
2026-07-22 15:42 ` [PATCH v2 00/17] Rewrite type instance flags as a struct with bitfields Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722-users-aktemur-type-instance-flags-v2-13-d60dcbc2a76f@amd.com \
--to=tankutbaris.aktemur@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox