From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WY70JFufYGox0CQAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 06:45:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=fEyoSpok; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8D7641E09E; Wed, 22 Jul 2026 06:45:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4C2EF1E099 for ; Wed, 22 Jul 2026 06:45:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCD4E4BA23CD for ; Wed, 22 Jul 2026 10:45:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCD4E4BA23CD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=fEyoSpok Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazlp170110009.outbound.protection.outlook.com [IPv6:2a01:111:f403:c111::9]) by sourceware.org (Postfix) with ESMTPS id 39E2D4BA23C5 for ; Wed, 22 Jul 2026 10:42:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 39E2D4BA23C5 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 39E2D4BA23C5 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c111::9 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716975; cv=pass; b=kDZV7iU9+7DfHcNb0XpeXGqqjm2foeGtJdx1SloXFDn1G602+9pSskColdfikQTQX/9u5Hqo8nKQkaNlFFwW6obpTKmbUzfzdOFuTaHM+9iKxKV/IIqjdXrCUgXWHMcIQXlCknVB9QNTj9nJZ77N0UU8eT3xjpnbjb5ctaUFZAc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716975; c=relaxed/simple; bh=VnxZjqZCv0j6/3VS9CyPAilEhqlR9zDG/P9Al/h9vhA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ARR9mPNjUnDiKEy2UFaBahIi2KdqP2NKN+3fui+5rB/YMuMB4XnaTXLX2A+R8AGoU1w8LZ68eyLr1lcjNIwjoDOGPIg1qLfyck4pejVbK3/iKscmZ9qxYsIibLxZI3WgdgJ/RidR+ABDDbK14hIQdmYWotWl39xpgMmMST95Dvw= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=fEyoSpok DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39E2D4BA23C5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bUYpffQbF7/Nk3dyGH2f8sYf2q7UNYjlkj5kej3RS7q5HVty7XwbN+6vX+wuIbKKYirtK4ZkvQI5u0zxdyDYtpnTnih/bo82rU0yPCaIYjyFLhCFltRkaQ16qNMkyYFMntwguqwrHl9bEeKqH54GX2UUXIFTr+Jx6trW818wcoyvF6kMGWV0X0aeoIfZfQowcMAFQ9K4s2VwXOdOpxj8Hm6duwcoMEYLwjjAl3u+kZsG/EuERGx6n04YMFwh9fVzQPJg70rdCJDUCx5DJ6Z8y0iS35+ZDf4dzXiqill+bLNfaJ9iI/vmbsPimafozQm6tiUOBJkAw5z3PrYdMrbUzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ssyp+Q1oKnt6qQhvPdjsZuW65kEfwK888vEhYLzV41s=; b=rLEJetS0jIvplbvLj9wrbGq/UHzL3WREuGWhbjTkb/hpB8iZhkBbAfaRIrttVMQJjcx4z0vrnQAdsBNQI4OJi1Bs04yO317jot8GYnJyWW7s3k45+6E+u0jxg4aTPxbcDiOt/OTB6pxCcPjMSMTGaHXh02Ief8Foc3rOwWAet3fCAwoUbIB7etcpdqs18NZscjBDZrHFtDr6MJPGkqQgYusP+GdtBahTmgschbrxbfhIjH8PTzpHLkVv1CoMpbzRXWvYUNUln8iasiPxrmLzGsuOS0fAZLoZONX+5ZIafQUvDwd/zJC6Br85/hm+1TtMntgRd0LalxgPKE51Dc0uJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ssyp+Q1oKnt6qQhvPdjsZuW65kEfwK888vEhYLzV41s=; b=fEyoSpokf9xAgKHO9RXarjymwtsIR4vJcyhVAwbmi/j1CEtfEd1aw0oyBeDTej40EE23gUja67HcBft5ibfq38OzsF1E3m3mfrdnBUdTn/EyQ/bW/orxNVi+FoQ+lmrv6hWx/gVEVqaMQrfO32KIp+ogfxpPgig+H+H7J1elMPE= Received: from CH0PR03CA0119.namprd03.prod.outlook.com (2603:10b6:610:cd::34) by CH2PR12MB4279.namprd12.prod.outlook.com (2603:10b6:610:af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 10:42:49 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:610:cd:cafe::2a) by CH0PR03CA0119.outlook.office365.com (2603:10b6:610:cd::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Wed, 22 Jul 2026 10:42:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.0 via Frontend Transport; Wed, 22 Jul 2026 10:42:49 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 22 Jul 2026 05:42:45 -0500 From: Tankut Baris Aktemur To: CC: Subject: [PATCH v2 13/17] gdb: convert TYPE_DATA_SPACE macro to type::is_data_space Date: Wed, 22 Jul 2026 05:42:02 -0500 Message-ID: <20260722-users-aktemur-type-instance-flags-v2-13-d60dcbc2a76f@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com> References: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|CH2PR12MB4279:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ffb8568-fae1-45c8-b337-08dee7ddf988 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|23010399003|82310400026|36860700016|6133799003|22082099003|18002099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: sRc7O1aB5JDDT2+6Ixg09KD0u9EI0ELgkLDB4bbPulPNblGPli52rfVx4+WdxDFiUdDf8m2WKjJ5UCl1d++w06ECf8yb6hVC41o8UBv3n1MHPnyJL9Cr//vbLuJz3u2a9fIRvRvin+A1Oj0VW1uICdzACwCUj4r6BDWUMD+6EFY0m0Hn0g+uppiIIAg3JNE/hCYPjUyyu891Qg3XVIuWacsGrJUm1wqKAB53JmV0wTml494wcQORKgva4AZFDGp1HvZi6yrXfhg72LPDZTn5e1XO9X1gBMS6ufAZpOvRGYj4gc1FI1Cxj9pSLhrOSPb/OZHA1FspjtIh4B91oXJxJC43bD/Yalxpkwd5S//VoHAz5WfYQEIpaDmWXfZdNaBwGp/DfV2BIwsGes20v3ffdOoXf/wkidFetRtniBf7ZII8LnMvDGvIpqNbNrmDMDXOmyIePJ0WIRWlpY8DcuMJ3MCvxDLn5S2r38c0THSnUIHYKs+gnv4104JcHqB+Gc5Jy0mi/PTvd1jes5GjEA2E0P0tn35DnfC7qs0EBtijg6GMxH02kdxxBvg+uQHqmb8uq0x+aGL3l4KUCvYcPPxuuA2GHOZoUgEu9auBr6FcnZT+ygx8DrkeI8GFaFtA8yewphsNtyqHLcgrVQVl7AS0+8rEfpKniW52kYLTYrzkgw/6TkHa00G1I+vIfkJCV0YW6CIQUeuqDqfaqjLBVVaKrA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(376014)(23010399003)(82310400026)(36860700016)(6133799003)(22082099003)(18002099003)(11063799006)(56012099006)(10067099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yJ3fkdYv1nAl69a8s+w6ljx+ymGznAc+GAQiUcpOKF5Q4bI+dRacFXl8kfKrZr0TpF2qiSm0n0Oz2Js8O8d3v/Ty7+SrvCejtakLbfRoLlAD/K6r1MN/zG5fm2jRyO5bPHQVqscDzCECQaq68NSGbKSvvOm/wOrCUmGhaMYL9XBzaaukDPUco3W1o00peRYRXx55y5SKqykx0WCxct98UA6wpk9+ik7aKI7SaJ/N/8du3FJPCctgo+TJo9mfXLFPMIbUpdObEt+xaewZ/5x2r/LDe2GoxFf9qG1M94vbezP0yYVuaMDlRJNOVmOFI1X6a1Xb21oXbj4KFO8Fnode81rjOjwKdt/OStSzl2x3pvgrCzt8rMqqWDsh86QcfGWLTAXrpOhdGB6mUGPAIPiF0iBxn2wplGEP3CVvpLcnAru5AWGFDiJ/cPoNINFlDP28 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 10:42:49.2926 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ffb8568-fae1-45c8-b337-08dee7ddf988 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4279 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Convert the TYPE_DATA_SPACE macro to a method of the type class. This is a refactoring. --- gdb/avr-tdep.c | 2 +- gdb/c-typeprint.c | 2 +- gdb/gdbtypes.c | 6 ++---- gdb/gdbtypes.h | 9 ++++++--- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c index 26b786c68b7..682b7e8586d 100644 --- a/gdb/avr-tdep.c +++ b/gdb/avr-tdep.c @@ -361,7 +361,7 @@ avr_integer_to_address (struct gdbarch *gdbarch, { ULONGEST addr = unpack_long (type, buf); - if (TYPE_DATA_SPACE (type)) + if (type->is_data_space ()) return avr_make_saddr (addr); else return avr_make_iaddr (addr); diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c index a8927e0ac43..d26640e10e6 100644 --- a/gdb/c-typeprint.c +++ b/gdb/c-typeprint.c @@ -487,7 +487,7 @@ c_type_print_modifier (struct type *type, struct ui_file *stream, if (type->is_code_space ()) address_space_id = "code"; - else if (TYPE_DATA_SPACE (type)) + else if (type->is_data_space ()) address_space_id = "data"; else if (gdbarch_address_class_id_to_name_p (type->arch ())) address_space_id diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 465af4790fd..731c7436dc6 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -5027,10 +5027,8 @@ recursive_dump_type (struct type *type, int spaces) gdb_puts (" TYPE_VOLATILE"); if (type->is_code_space ()) gdb_puts (" TYPE_CODE_SPACE"); - if (TYPE_DATA_SPACE (type)) - { - gdb_puts (" TYPE_DATA_SPACE"); - } + if (type->is_data_space ()) + gdb_puts (" TYPE_DATA_SPACE"); if (TYPE_ADDRESS_CLASS (type) != 0) { gdb_printf (" TYPE_ADDRESS_CLASS(%u)", TYPE_ADDRESS_CLASS (type)); diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index d9988312e1b..b6c3b219419 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -189,9 +189,6 @@ struct type_instance_flags (((t)->dyn_prop (DYN_PROP_BYTE_SIZE) != nullptr) \ || ((t)->dyn_prop (DYN_PROP_BIT_SIZE) != nullptr)) -#define TYPE_DATA_SPACE(t) \ - (((t)->instance_flags ()).harvard_aspace == HARVARD_ASPACE_DATA) - #define TYPE_ADDRESS_CLASS(t) \ (((t)->instance_flags ()).address_class) @@ -1219,6 +1216,12 @@ struct type return this->m_instance_flags.harvard_aspace == HARVARD_ASPACE_CODE; } + /* Return if this type is in the data space. */ + bool is_data_space () const + { + return this->m_instance_flags.harvard_aspace == HARVARD_ASPACE_DATA; + } + /* Get the bounds bounds of this type. The type must be a range type. */ range_bounds *bounds () const { -- 2.34.1