From: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <tom@tromey.com>
Subject: [PATCH v2 15/17] gdb: convert TYPE_ATOMIC macro to type::is_atomic
Date: Wed, 22 Jul 2026 05:42:04 -0500 [thread overview]
Message-ID: <20260722-users-aktemur-type-instance-flags-v2-15-d60dcbc2a76f@amd.com> (raw)
In-Reply-To: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com>
Convert the TYPE_ATOMIC macro to a method of the type class. This
is a refactoring.
---
gdb/c-typeprint.c | 4 ++--
gdb/gdbtypes.c | 6 ++----
gdb/gdbtypes.h | 8 ++++++--
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c
index 1c3b0fba04d..92938270647 100644
--- a/gdb/c-typeprint.c
+++ b/gdb/c-typeprint.c
@@ -322,7 +322,7 @@ cp_type_print_method_args (struct type *mtype,
? " __restrict__"
: " restrict"));
- if (TYPE_ATOMIC (domain))
+ if (domain->is_atomic ())
gdb_printf (stream, " _Atomic");
}
}
@@ -475,7 +475,7 @@ c_type_print_modifier (struct type *type, struct ui_file *stream,
did_print_modifier = 1;
}
- if (TYPE_ATOMIC (type))
+ if (type->is_atomic ())
{
if (did_print_modifier || need_pre_space)
gdb_printf (stream, " ");
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index a682d525134..34eaac42e20 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -5035,10 +5035,8 @@ recursive_dump_type (struct type *type, int spaces)
}
if (type->is_restrict ())
gdb_puts (" TYPE_RESTRICT");
- if (TYPE_ATOMIC (type))
- {
- gdb_puts (" TYPE_ATOMIC");
- }
+ if (type->is_atomic ())
+ gdb_puts (" TYPE_ATOMIC");
gdb_puts ("]\n");
gdb_printf ("%*sflags", spaces, "");
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index 0acfda0d74b..624d468e4f2 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -168,8 +168,6 @@ struct type_instance_flags
bool is_atomic : 1;
};
-#define TYPE_ATOMIC(t) (((t)->instance_flags ()).is_atomic)
-
/* True if this type represents either an lvalue or lvalue reference type. */
#define TYPE_IS_REFERENCE(t) \
@@ -1227,6 +1225,12 @@ struct type
return this->m_instance_flags.is_restrict;
}
+ /* Return if this type is atomic. */
+ bool is_atomic () const
+ {
+ return this->m_instance_flags.is_atomic;
+ }
+
/* Get the bounds bounds of this type. The type must be a range type. */
range_bounds *bounds () const
{
--
2.34.1
next prev parent reply other threads:[~2026-07-22 10:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 10:41 [PATCH v2 00/17] Rewrite type instance flags as a struct with bitfields Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 01/17] gdb: use type instance macros to query const, volatile, restrict Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 02/17] gdb: convert address_class_type_flags_to_name to address_class_id_to_name Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 03/17] gdb: convert address_class_name_to_type_flags to address_class_name_to_id Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 04/17] gdb: convert address_class_type_flags to address_class_dwarf_to_id Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 05/17] gdb: refactor type_stack::insert methods Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 06/17] gdb: inline address_space_{name, type_instance_flags}_to_{type_instance_flags, name} Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 07/17] gdb: split make_type_with_address_space Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 08/17] gdb: convert type instance flags to bitfields Tankut Baris Aktemur
2026-07-24 19:10 ` Keith Seitz
2026-07-22 10:41 ` [PATCH v2 09/17] gdb: convert TYPE_NOTTEXT macro to type::is_nottext Tankut Baris Aktemur
2026-07-22 10:41 ` [PATCH v2 10/17] gdb: convert TYPE_CONST macro to type::is_const Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 11/17] gdb: convert TYPE_VOLATILE macro to type::is_volatile Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 12/17] gdb: convert TYPE_CODE_SPACE macro to type::is_code_space Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 13/17] gdb: convert TYPE_DATA_SPACE macro to type::is_data_space Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 14/17] gdb: convert TYPE_RESTRICT macro to type::is_restrict Tankut Baris Aktemur
2026-07-22 10:42 ` Tankut Baris Aktemur [this message]
2026-07-22 10:42 ` [PATCH v2 16/17] gdb: convert TYPE_ADDRESS_CLASS macro to type::address_class Tankut Baris Aktemur
2026-07-22 10:42 ` [PATCH v2 17/17] gdb: remove unnecessary braces in recursive_dump_type Tankut Baris Aktemur
2026-07-22 15:42 ` [PATCH v2 00/17] Rewrite type instance flags as a struct with bitfields Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722-users-aktemur-type-instance-flags-v2-15-d60dcbc2a76f@amd.com \
--to=tankutbaris.aktemur@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox