Re: [PATCH v1 05/10] gdb: introduce helper class file_reader_t

[Kevin Buettner <kevinb@redhat.com>]

On Tue, 7 Jul 2026 16:48:55 +0100
Matthieu Longo <matthieu.longo@arm.com> wrote:

> diff --git a/gdb/target.h b/gdb/target.h
> index 4215553033c..d6fc101f205 100644
> --- a/gdb/target.h
> +++ b/gdb/target.h
> @@ -2338,6 +2338,71 @@ extern LONGEST target_fileio_read_alloc (struct inferior *inf,
>  extern gdb::unique_xmalloc_ptr<char> target_fileio_read_stralloc
>      (struct inferior *inf, const char *filename, size_t *len = nullptr);
>  
> +/* Helper class for reading a file.  */
> +template <typename T>
> +class file_reader_t
> +{
> +  /* The filepath of the file being read.  */
> +  std::string m_filepath;
> +  /* Smart pointer to the data.  */
> +  gdb::unique_xmalloc_ptr<T> m_data;
> +  /* Size of the data.  */
> +  size_t m_size;
> +
> +public:
> +  file_reader_t (const std::string &filepath)
> +    : m_filepath (filepath)
> +    , m_size (0)
> +  {
> +    if constexpr (std::is_same_v<T, char>)
> +      m_data = target_fileio_read_stralloc (nullptr, m_filepath.c_str (),
> +					    &m_size);
> +    else
> +      {
> +	gdb_byte *buf = nullptr;
> +	m_size = target_fileio_read_alloc (nullptr, m_filepath.c_str (), &buf);

m_size is a size_t, which is unsigned.  But target_fileio_read_alloc
returns a signed value and if it fails, the return value will be -1,
right?  I think you need to handle this case somehow...

Kevin