From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AZsgAZJnUWoWLwIAWB0awg (envelope-from ) for ; Fri, 10 Jul 2026 17:43:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=C1EBHPBk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EA5C21E070; Fri, 10 Jul 2026 17:43:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 948011E070 for ; Fri, 10 Jul 2026 17:43:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 63AC54BA2E39 for ; Fri, 10 Jul 2026 21:43:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63AC54BA2E39 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=C1EBHPBk Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id AA6B64BA5435 for ; Fri, 10 Jul 2026 21:43:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA6B64BA5435 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA6B64BA5435 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783719800; cv=none; b=ADGOPNhCxzTqoeO7K3YHqo9ZfRI4ika9ulQfNnnmtDBIryCzmT9aktnOPZrvNwhSV0N2iUtQtLNj5RVSdQsfuAtXr4E3dC/8XLz2kuz/ovzic/Zvo6+qU/XdyNulrkgdZoL18YwhXXmbKzcMaoyFmJ0Dp9Bv99pDjkX6a9lylc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783719800; c=relaxed/simple; bh=7uYieyohPpMNodcZVKYJSNv46G+PSoEGlnHJiO+OMXk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=BVSs+qi5gm1ygggNr5peT9DAH2J5/TrhIEBe6rRIo0I9Hoyn4iKrqnTDhvur7dq+kwMHsNz3Ayjw4Rpu2J/S3AX++QMZDTXakxrTYooCjImBeXbC4mF9xmyzFBdvXuGmrFALfpppNiBXbWD4jytIXpSNKt8lYLUhsKDG8ofZG4M= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=C1EBHPBk DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA6B64BA5435 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783719800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvbqLZOwmjX7rl70WZ4ALQfHP5gUlJRDtvJiWAJinVU=; b=C1EBHPBk+ka4YJCBugniG71kNr3giT50tD8juNvzmyJXY4Wc27U+WTRwKWMhN0dvk+ljVU n0L4jQQ3+B3pH7tyDFnLP+ec+qM/9ZrJ0F5Xc908g6vvbKxtSNkBLXV2efQY6XDVx5Mjim AvGzRlCzhraFUm/2Zy9LB8/kTSH9ypo= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-MLAxS0F_Owmu1B7KTCKErA-1; Fri, 10 Jul 2026 17:43:17 -0400 X-MC-Unique: MLAxS0F_Owmu1B7KTCKErA-1 X-Mimecast-MFC-AGG-ID: MLAxS0F_Owmu1B7KTCKErA_1783719796 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D9C041956068; Fri, 10 Jul 2026 21:43:15 +0000 (UTC) Received: from f44-mesa-1 (unknown [10.22.88.58]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BFDE53000B4D; Fri, 10 Jul 2026 21:43:14 +0000 (UTC) Date: Fri, 10 Jul 2026 14:43:12 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Matthieu Longo Subject: Re: [PATCH v1 05/10] gdb: introduce helper class file_reader_t Message-ID: <20260710144312.7651f3ad@f44-mesa-1> In-Reply-To: <20260707154900.94542-6-matthieu.longo@arm.com> References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-6-matthieu.longo@arm.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JkVpjpP2ilUv6qsy6STbu2aqc0Vu9kdLT-XdmXh6gzk_1783719796 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 7 Jul 2026 16:48:55 +0100 Matthieu Longo wrote: > diff --git a/gdb/target.h b/gdb/target.h > index 4215553033c..d6fc101f205 100644 > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -2338,6 +2338,71 @@ extern LONGEST target_fileio_read_alloc (struct inferior *inf, > extern gdb::unique_xmalloc_ptr target_fileio_read_stralloc > (struct inferior *inf, const char *filename, size_t *len = nullptr); > > +/* Helper class for reading a file. */ > +template > +class file_reader_t > +{ > + /* The filepath of the file being read. */ > + std::string m_filepath; > + /* Smart pointer to the data. */ > + gdb::unique_xmalloc_ptr m_data; > + /* Size of the data. */ > + size_t m_size; > + > +public: > + file_reader_t (const std::string &filepath) > + : m_filepath (filepath) > + , m_size (0) > + { > + if constexpr (std::is_same_v) > + m_data = target_fileio_read_stralloc (nullptr, m_filepath.c_str (), > + &m_size); > + else > + { > + gdb_byte *buf = nullptr; > + m_size = target_fileio_read_alloc (nullptr, m_filepath.c_str (), &buf); m_size is a size_t, which is unsigned. But target_fileio_read_alloc returns a signed value and if it fails, the return value will be -1, right? I think you need to handle this case somehow... Kevin