* [PATCH] gdb/testsuite: fix regexp in gdb.rocm/watchpoint-at-end-of-shader.exp @ 2026-05-20 9:13 Tankut Baris Aktemur 2026-05-20 11:13 ` Lancelot SIX 0 siblings, 1 reply; 3+ messages in thread From: Tankut Baris Aktemur @ 2026-05-20 9:13 UTC (permalink / raw) To: gdb-patches; +Cc: lancelot.six The following tests fail: FAIL: gdb.rocm/watchpoint-at-end-of-shader.exp: precise_memory=on: continue FAIL: gdb.rocm/watchpoint-at-end-of-shader.exp: precise_memory=off: continue The reason is a difference in outputs seen in upstream and downstream branches. Fix the regexps to avoid the failures. --- gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp index ff233c8b26a..ea88c1269b7 100644 --- a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp +++ b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp @@ -71,9 +71,9 @@ proc do_test {precise_memory has_xfail} { setup_xfail "*-*-*" } gdb_test "continue" \ - [multi_line "Switching to thread $::decimal, lane 0.*" \ + [multi_line "Switching to \[^\r\n\]+(?=\r\n)" \ "" \ - "Thread $::decimal \".*\" hit Hardware watchpoint $::decimal: -location \\*v" \ + "Thread $::decimal \[^\r\n\]*hit Hardware watchpoint $::decimal: -location \\*v" \ "" \ "Old value = 64" \ "New value = 8" \ -- 2.34.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb/testsuite: fix regexp in gdb.rocm/watchpoint-at-end-of-shader.exp 2026-05-20 9:13 [PATCH] gdb/testsuite: fix regexp in gdb.rocm/watchpoint-at-end-of-shader.exp Tankut Baris Aktemur @ 2026-05-20 11:13 ` Lancelot SIX 2026-05-20 11:26 ` Aktemur, Baris 0 siblings, 1 reply; 3+ messages in thread From: Lancelot SIX @ 2026-05-20 11:13 UTC (permalink / raw) To: Tankut Baris Aktemur, gdb-patches Hi, Thanks for fixing this. On 20/05/2026 10:13, Tankut Baris Aktemur wrote: > The following tests fail: > > FAIL: gdb.rocm/watchpoint-at-end-of-shader.exp: precise_memory=on: continue > FAIL: gdb.rocm/watchpoint-at-end-of-shader.exp: precise_memory=off: continue > > The reason is a difference in outputs seen in upstream and downstream > branches. Fix the regexps to avoid the failures. > --- > gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > index ff233c8b26a..ea88c1269b7 100644 > --- a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > +++ b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > @@ -71,9 +71,9 @@ proc do_test {precise_memory has_xfail} { > setup_xfail "*-*-*" > } > gdb_test "continue" \ > - [multi_line "Switching to thread $::decimal, lane 0.*" \ > + [multi_line "Switching to \[^\r\n\]+(?=\r\n)" \ Wouldn't a simple "$" work rather than the look-ahead "(?=\r\n)"? Anyway, both should be ok. Best, Lancelot. Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu) > "" \ > - "Thread $::decimal \".*\" hit Hardware watchpoint $::decimal: -location \\*v" \ > + "Thread $::decimal \[^\r\n\]*hit Hardware watchpoint $::decimal: -location \\*v" \ > "" \ > "Old value = 64" \ > "New value = 8" \ ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] gdb/testsuite: fix regexp in gdb.rocm/watchpoint-at-end-of-shader.exp 2026-05-20 11:13 ` Lancelot SIX @ 2026-05-20 11:26 ` Aktemur, Baris 0 siblings, 0 replies; 3+ messages in thread From: Aktemur, Baris @ 2026-05-20 11:26 UTC (permalink / raw) To: Six, Lancelot, gdb-patches AMD General On Wednesday, May 20, 2026 1:14 PM, Six, Lancelot wrote: > Hi, > > Thanks for fixing this. > > On 20/05/2026 10:13, Tankut Baris Aktemur wrote: > > The following tests fail: > > > > FAIL: gdb.rocm/watchpoint-at-end-of-shader.exp: precise_memory=on: continue > > FAIL: gdb.rocm/watchpoint-at-end-of-shader.exp: precise_memory=off: continue > > > > The reason is a difference in outputs seen in upstream and downstream > > branches. Fix the regexps to avoid the failures. > > --- > > gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > > index ff233c8b26a..ea88c1269b7 100644 > > --- a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > > +++ b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > > @@ -71,9 +71,9 @@ proc do_test {precise_memory has_xfail} { > > setup_xfail "*-*-*" > > } > > gdb_test "continue" \ > > - [multi_line "Switching to thread $::decimal, lane 0.*" \ > > + [multi_line "Switching to \[^\r\n\]+(?=\r\n)" \ > > Wouldn't a simple "$" work rather than the look-ahead "(?=\r\n)"? No, not necessarily, because the buffer has more data in it, which we want to match with the other lines. > > Anyway, both should be ok. > > Best, > Lancelot. > > Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu) Thank you. Pushed. -Baris ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-20 11:27 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-05-20 9:13 [PATCH] gdb/testsuite: fix regexp in gdb.rocm/watchpoint-at-end-of-shader.exp Tankut Baris Aktemur 2026-05-20 11:13 ` Lancelot SIX 2026-05-20 11:26 ` Aktemur, Baris
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox