From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qWyzE4WXDWrOJQoAWB0awg (envelope-from ) for ; Wed, 20 May 2026 07:14:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=RpIPtbFr; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2CF881E098; Wed, 20 May 2026 07:14:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6EA7D1E062 for ; Wed, 20 May 2026 07:14:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE0864BB8F63 for ; Wed, 20 May 2026 11:14:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE0864BB8F63 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=RpIPtbFr Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011054.outbound.protection.outlook.com [52.101.57.54]) by sourceware.org (Postfix) with ESMTPS id D56CA4BBC082 for ; Wed, 20 May 2026 11:13:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D56CA4BBC082 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D56CA4BBC082 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.57.54 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1779275625; cv=pass; b=O8oF+RZgpsBMtWEDgE3Jc6p+Y0Ehe+JTsQvmO4n7VC7UYUpQK86CEAwuQv0psyNacP9uoXLyoPHTMzfxxGuKmFKCgvKHLpE7v4+nWQlJ1Im+eJGfwr53ix+jZmHG0MD7lsEtcdiDEAbQsEk9VP7k98hRqM+61df1xtYigtM9oSI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1779275625; c=relaxed/simple; bh=8xpChFuWu+VKtUiZE/t+JmUM/yHs/qFD1NUc8pCOV9Q=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=taLSgzGRrkMPgQRL9IWL7u3Lx39+5peShRUUInQCfmsWUhV2PIQ22gctNu2TGFYlnZ5NAVnIH/WXeBnJ6n/At4PuvoGaNMZa+Xc0uCGXj1gMG/PxIBFjajKFISLKk2j7JbD11pBUU8C6SQh2w0igAdJBiqp4xQv5nSj3ZaemVRk= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=RpIPtbFr DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D56CA4BBC082 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oRj7hHpR5AeRBP6aZ0fTCU7YpSkwSRHzmuKinMVFC4x9U7cBwfQu31RsksJjW2D/dAfqvQf0EFJZneNyYugrsZoJ4FinTwBy6vauSYJ7bQ7QzIF07WHONG6Jei2fHges7CeWurAdrwHENNwjnIGsEDedjyGhBYP1QCyVTns0VdirpuZbfBTaXqiPtZc1BxNd6xlGS6EiF9FoCLXKg2A0d+Zv+sWpAKxqFmRV8ud9XRG9cmKINE0gSTbZeshWg1ZjGZ7U3w1m6KrWPlP4QWkJRhpl7jwuGozPSPKkOQfyS/eLQOOJG3GmJfJ2qfTlY2iCKw5oYWxzScHlUQHg4Tgyzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IG1L9yImU9pBOpUR5lPXmW7cLeFO7INwFFEHJZVqYhc=; b=C2i82oQCvjj7038Hweqp1QVXupIyLMjF0ELygO1hpgyN0rw+CW/Kka3rzwfJfMMv/scBH2oYObAUiDVqFvY7o1/w+XRdeZWvUdkLB8XLa2Mt1yL9yb0S5BRrGGYEkgR/aaFmC/hS0MXMZTRA8cFat4eHFfG4RIqEkquXp5WAepvgKR/aIFCP0kMsTbp3765gfpHcrCjxlxcWpBApE00g7ycoEMPa/n0EeptrwWIqpaYZgUFMn+1jj+Ez+sx/lFIws6RmPygJpHmKsDB6tvn+eOp5wSEU8V7zr6fDQ7i9uy9kpqA6bNM1HIhRl8FXOzIEd2wh76jGK3w8H0azB7HcHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IG1L9yImU9pBOpUR5lPXmW7cLeFO7INwFFEHJZVqYhc=; b=RpIPtbFrZ7uzrqtzwaLvMK9i3ff5aP/ii0UivjeYSplZoyY4qiQ7mU534ptJBotqEljNvpFNsvg1uj4o6lNDSCPZ79w6brHbwus9TajxpRVTYXMGVce5Y1WSxASdaBwgywXJJrXn4WFaLdAtQ7Gq9Iiko03iVzHua/HZUlI2k8g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by CH1PPF189669351.namprd12.prod.outlook.com (2603:10b6:61f:fc00::608) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.22; Wed, 20 May 2026 11:13:38 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3%5]) with mapi id 15.21.0048.016; Wed, 20 May 2026 11:13:38 +0000 Message-ID: Date: Wed, 20 May 2026 12:13:33 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: fix regexp in gdb.rocm/watchpoint-at-end-of-shader.exp To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <20260520091346.1332979-1-tankutbaris.aktemur@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20260520091346.1332979-1-tankutbaris.aktemur@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::17) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|CH1PPF189669351:EE_ X-MS-Office365-Filtering-Correlation-Id: f845fb6c-762a-4b66-1429-08deb660d732 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|3023799007|13003099007|56012099003|18002099003|22082099003|11063799006|5023799004; X-Microsoft-Antispam-Message-Info: KTRv138r6ioV7UZFIcUk4PUV9y8zSt0Iaxurq1hHXjPPNCb8uEyFVU88DvztuBbBABw7d8REYCUcNftiNWBKPpB6VSvRZyKeZQPXZ0rLMLz2wKs1vhlKm4hekrowYXEciaV/X0UHvG9zVf6kTqZWE0rFeQDVAsnxoBpWOn4Z6+/CELuGJ5+HTGVvGnLzXioE9/GE3Dz8TOcJTfbc6dQWKQVVAkULhtpkNK4x0VbmlQNrOvy4LSdOu7r7ZdCOaLn7dBYk2e7JuvmttFMitr7vxcbiB2kQGM48XZM7ST5MB+qKemqiDFsxEsxCd4YhefecXJ+03kuZc+T8r5iHrKp490she9FRAoGO8yERiyIDk1+mAMbuxyvX4XKpenVY3HuSok97CL+zDemdGP7BgpWuhxYVxElzkengPyndPIYrEw3FyPKZGnnDtNkVI4TFxShg9icJTsat9TnAe/7sm4/fO84h5gPh3BlBqWoCutfDR7Ty4CRLZUza7lROKsMJNOcl2m6cQdhWCda1/+BzecZsPPvxnawvNTpueGBO7NdYAkoCLo1+YM5MY48Fij4cpnLqoS3/aWkM5OyC8FCXJlsH6NogVTfrvqOJX0IhREmE+ItnKf7mU5rPSAPt0LmJed9h862CaBH8JTLazWcEB/Vr2A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(3023799007)(13003099007)(56012099003)(18002099003)(22082099003)(11063799006)(5023799004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXFkZHgzN0FuOWZSL2NLSXZHUk5SK01ML0VUdXFSdnpZd1ZGY09MeFhqMkxR?= =?utf-8?B?ajJDdnA1T1NRY1N1UXM0SGk3blV1TXo5Ylp1Mk10RXlFQXhGSHh4TzQzRU5Y?= =?utf-8?B?a2kyaFhYRmg1ckN3aWQ3cXJrV290UXE0RTViSzdEd2NES0N3WXFvTWFGYUtW?= =?utf-8?B?VHJlcmNkcUZhNGNTdFhIZ2NWNWJMdnFQQ3ByYytVOWtMb0RJZi9iMUY2UTMz?= =?utf-8?B?a2VrVVFPelY5T0VndDBtMHo0V29zQVZYYTZ0bGlXSnY4cHNjSTJzSXFqbmxT?= =?utf-8?B?cHVWaC82d3Q1OS9kdHAvSE95aG9qaVBsV29ETjVJZUZhQkt6SGwyWE92TFoy?= =?utf-8?B?SFlYSHp2K3RDVVJhQnpmWENxcXd3Z1I3Z1RaYXQxemtKSURpZTRoWmRJM2ZL?= =?utf-8?B?d2srN0M4S2tuUFp3RXdzRitqVGVyQ0JrMmNEYWpDZUlPVnRuSVJUTU5KZ3ZK?= =?utf-8?B?NkVZZ2h0clV3eStqUDcrMEQrWUhpN2Z6TTVTNjRFazJ6SW9mMlFzeGxMMXdT?= =?utf-8?B?Y2FmdnR6K050dGptMWFUSlM3aUVBemR0cnZ0S0h4TGRaWEpaNTVjU2xGM1R4?= =?utf-8?B?anRvbFdkMWhubFJDSTdMNnhNMG5lK2dZZVRKRm5iTUZWUldXRFBycU16cmRs?= =?utf-8?B?MjQyTkkwWjVrOGVINitOOVp1Z1JDT0ZHVkhUWm53UkV4ZnUwQ3dCUW1IRk43?= =?utf-8?B?N0Ftb2dZYmU1MExpcm92b3ZoOUx3N05WaDlueFJhTzFxUjN1UDVKL1pmTzhJ?= =?utf-8?B?Y0tUbVRDZTNocEVudTRIMVNCYTJjdFppUXBLeHdiRDNneGpMOG1JSS9LaE9G?= =?utf-8?B?UXh3ZCtYdkVGOEtiNXAxMFJiNzR6WlNaU2JDRFR4UjhySzVLaytpYTUyaW5Q?= =?utf-8?B?WFIrdFYwWTNTc2IxWlRIcGQzLzg1V3g2ZHk4Si82MHlxZDgrYWxVN21PN2J6?= =?utf-8?B?dW1neDR2UTdab3VnbzA1Mm5ramNscm5KZlY5b1N1ZDhGaDdFTkNTcUJrS21o?= =?utf-8?B?NnUzQTdick11WjBYNU92eVE4VUZ2WXpOeHEwTW1jT2RJMi9jT21mVDR4R0p0?= =?utf-8?B?bVZOT3BHZlNtSmJKbWRyMWJYZk1TWERESmYraklMemlsYnQrLzdxdm1ZSmFl?= =?utf-8?B?L0tHYWx1c3llQ2cxcnZpR1BBcnlCcy81SThtSTl2QjJRWVVJbVV5d2dVSUF5?= =?utf-8?B?Nkt2NEJaRlFFWGErRmhQaXZWY2pic2hpZ1pOamorNmk4RUNUdHRIUUNZelIw?= =?utf-8?B?SC9Od05uYWZYdjFIM1ZySWJ5UWMwa0lXaGR5eVQ0cmo0NElxNnpIU0ZuRUlT?= =?utf-8?B?MGNuNnduTjNBbFVJSFRIQlE3RTR2UW1ocjlJL2I3M1l0RVFYdFZKTkRJT1lD?= =?utf-8?B?em5LZ3RHMHBScHEvTkpncUZRTENFeHM4Mld4V0UxV1FqbGJLT1NEcnEyM0ly?= =?utf-8?B?b3JPcEFUSGwwWVQrSER0VVFmSVEwYzI0TjFVMHBRa216L0tGb2dJMkx4RldR?= =?utf-8?B?c3dkMGVwb3VtcExzVTJlUHQ1aXQvaXRWYk91bXZWT01PYlhDWHllbkFzVTdn?= =?utf-8?B?WDQ1TDdxbGdWSGg3NmxTSDlSd20rUEJIdmdIY0k0dDl4Y05pRVhHaG5RMDds?= =?utf-8?B?UVhOam13MmtZQlpGZFhzUzZOcVlzWTVZOThkdUFIaXFXSEhKS3dzSGs5dXI5?= =?utf-8?B?VkpYeTN1TGNhRkx6R09uNGVIQ29CaTFsOEtLQVpMbFZOQVlDeUtlZTZHMXA1?= =?utf-8?B?M3g0ZEtLbWhPamd4eTJFV1g3QUdVdTJScmRJVnNSdy9GMmhFanhwMWJDTTky?= =?utf-8?B?eURqMnkrT2FBNjNXMjBXTHZQZ1NMa3ZwZzRyMXFoRUVHckkyenI0bWdIUlRy?= =?utf-8?B?b2lialh1WGdWNnVDUXdhSTBnYURkV0Nra2RLNHZUaGhGTmx3Q3hzMzlybi9p?= =?utf-8?B?aWFXSFJjUytmd2FvYkxNOTNWeUNuRmhLYUZ1Qkx3YzF5bzBjMGVyL2hMQVlP?= =?utf-8?B?OHArSGh0WmhTcStzUm1OeUtFU21nWUtQUVZqM1Y0S3ZRSHF0WmlLazR3cVhD?= =?utf-8?B?TjM5akxHK0g5b3U2a0lpV2t4bFdkaTNZVU9yVTJTUERYaU52T2cxdmQrS1pr?= =?utf-8?B?UlpMdUpGZGdXS1BzZ0RVUjNody9EUUpHd1ZLRjRYTG5TWUhvb2M4dzRyYlh0?= =?utf-8?B?bzBWU2Z6M0dsY2d1N0YzeUJNbElVNHBBUFBQR3ZWUmQ4T3U0NWQrNkV0a0pn?= =?utf-8?B?RmEyTXlCWDRoczVEMWxGNHNrZ0F1dU9HU1QyNnRCSDI4V0FuU3dURS96NFJK?= =?utf-8?Q?oY8eKm+/1p/OWjcB0P?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f845fb6c-762a-4b66-1429-08deb660d732 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2026 11:13:37.8846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2S2pse2R35wq9Sqq9Hn+9N3U7AB5j5+ToJH9AsBcow2txMFgxbcg6+mkov5OktehcyS5GplYQjWFodsgRcJiiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PPF189669351 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, Thanks for fixing this. On 20/05/2026 10:13, Tankut Baris Aktemur wrote: > The following tests fail: > > FAIL: gdb.rocm/watchpoint-at-end-of-shader.exp: precise_memory=on: continue > FAIL: gdb.rocm/watchpoint-at-end-of-shader.exp: precise_memory=off: continue > > The reason is a difference in outputs seen in upstream and downstream > branches. Fix the regexps to avoid the failures. > --- > gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > index ff233c8b26a..ea88c1269b7 100644 > --- a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > +++ b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp > @@ -71,9 +71,9 @@ proc do_test {precise_memory has_xfail} { > setup_xfail "*-*-*" > } > gdb_test "continue" \ > - [multi_line "Switching to thread $::decimal, lane 0.*" \ > + [multi_line "Switching to \[^\r\n\]+(?=\r\n)" \ Wouldn't a simple "$" work rather than the look-ahead "(?=\r\n)"? Anyway, both should be ok. Best, Lancelot. Approved-by: Lancelot Six (amdgpu) > "" \ > - "Thread $::decimal \".*\" hit Hardware watchpoint $::decimal: -location \\*v" \ > + "Thread $::decimal \[^\r\n\]*hit Hardware watchpoint $::decimal: -location \\*v" \ > "" \ > "Old value = 64" \ > "New value = 8" \