From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 2/2] gdb: move call to clear_symtab_users out from finish_new_objfile
Date: Wed, 1 Apr 2026 10:21:06 -0700 [thread overview]
Message-ID: <20260401102106.463912ae@f42-zbm-amd> (raw)
In-Reply-To: <bd7668dfe915df1d7a4aa3f772c146a19024c4a9.1774966728.git.aburgess@redhat.com>
Hi Andrew,
Both parts LGTM. I have just one nit...
On Tue, 31 Mar 2026 15:20:18 +0100
Andrew Burgess <aburgess@redhat.com> wrote:
> + set_auto_load_safe_path $remote_python_file \
> + [file dirname ${objcopy_binfile}]
> + gdb_load $objcopy_binfile
I'd like to see a comment added for this call to
set_auto_load_safe_path, perhaps something like:
# Add directory because scripts are auto-loaded from the separate
# .debug file (not the main executable), which resides alongside
# it here.
For both parts:
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2026-04-01 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 14:20 [PATCH 0/2] move call to clear_symtab_users Andrew Burgess
2026-03-31 14:20 ` [PATCH 1/2] gdb/testsuite: modernise the gdb.python/py-section-script.exp test Andrew Burgess
2026-03-31 14:20 ` [PATCH 2/2] gdb: move call to clear_symtab_users out from finish_new_objfile Andrew Burgess
2026-04-01 17:21 ` Kevin Buettner [this message]
2026-04-02 9:28 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401102106.463912ae@f42-zbm-amd \
--to=kevinb@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox