Re: [PATCH 2/2] gdb: move call to clear_symtab_users out from finish_new_objfile

Andrew Burgess
2026-04-02T09:28:43Z

Kevin Buettner <kevinb@redhat.com> writes:

> Hi Andrew,
>
> Both parts LGTM. I have just one nit...
>
> On Tue, 31 Mar 2026 15:20:18 +0100
> Andrew Burgess <aburgess@redhat.com> wrote:
>
>> + set_auto_load_safe_path $remote_python_file \
>> + [file dirname ${objcopy_binfile}]
>> + gdb_load $objcopy_binfile
>
> I'd like to see a comment added for this call to
> set_auto_load_safe_path, perhaps something like:
>
> # Add directory because scripts are auto-loaded from the separate
> # .debug file (not the main executable), which resides alongside
> # it here.
>
> For both parts:
>
> Approved-by: Kevin Buettner <kevinb@redhat.com>

I added a comment as you suggested, and pushed these patches.

Thanks,
Andrew